You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/07 15:34:35 UTC

[GitHub] [kafka] cadonna opened a new pull request #9258: MINOR: Add unit tests for StreamsRebalanceListener

cadonna opened a new pull request #9258:
URL: https://github.com/apache/kafka/pull/9258


   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #9258: MINOR: Add unit tests for StreamsRebalanceListener

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #9258:
URL: https://github.com/apache/kafka/pull/9258


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #9258: MINOR: Add unit tests for StreamsRebalanceListener

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #9258:
URL: https://github.com/apache/kafka/pull/9258#issuecomment-688775571


   The following tests failed for JDK 15:
   
   ```
   kafka.network.ConnectionQuotasTest.testNoConnectionLimitsByDefault
   ```
   
   The following tests failed for JDK 8:
   
   ```
   org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] 
   org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9258: MINOR: Add unit tests for StreamsRebalanceListener

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9258:
URL: https://github.com/apache/kafka/pull/9258#issuecomment-693030043


   LGTM!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #9258: MINOR: Add unit tests for StreamsRebalanceListener

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #9258:
URL: https://github.com/apache/kafka/pull/9258#issuecomment-688397112


   Call for review: @vvcephei @guozhangwang @mjsax @ableegoldman @wcarlson5 @abbccdda 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #9258: MINOR: Add unit tests for StreamsRebalanceListener

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #9258:
URL: https://github.com/apache/kafka/pull/9258#issuecomment-688768874


   Retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org