You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/16 10:47:40 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18394: Refactor lock judge engine by SPI
codecov-commenter commented on PR #18394:
URL: https://github.com/apache/shardingsphere/pull/18394#issuecomment-1157516155
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18394](https://codecov.io/gh/apache/shardingsphere/pull/18394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ffda15) into [master](https://codecov.io/gh/apache/shardingsphere/commit/82a4ac0fbf83a8ef78400000ed2b58b37dc51ae9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82a4ac0) will **increase** coverage by `0.05%`.
> The diff coverage is `87.50%`.
```diff
@@ Coverage Diff @@
## master #18394 +/- ##
============================================
+ Coverage 59.10% 59.15% +0.05%
Complexity 2198 2198
============================================
Files 3741 3723 -18
Lines 54821 54802 -19
Branches 9311 8013 -1298
============================================
+ Hits 32403 32420 +17
+ Misses 19660 19617 -43
- Partials 2758 2765 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...de/manager/lock/ShardingSphereLockJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9sb2NrL1NoYXJkaW5nU3BoZXJlTG9ja0p1ZGdlRW5naW5lLmphdmE=) | `75.00% <82.35%> (+3.57%)` | :arrow_up: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9Db250ZXh0TWFuYWdlci5qYXZh) | `63.05% <100.00%> (+0.12%)` | :arrow_up: |
| [...here/mode/manager/lock/LockJudgeEngineBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9sb2NrL0xvY2tKdWRnZUVuZ2luZUJ1aWxkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...end/communication/DatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `29.68% <100.00%> (+0.45%)` | :arrow_up: |
| [...der/statement/ddl/CreateTableStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RkbC9DcmVhdGVUYWJsZVN0YXRlbWVudENvbnRleHQuamF2YQ==) | `78.57% <0.00%> (-17.09%)` | :arrow_down: |
| [...nder/statement/ddl/AlterTableStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RkbC9BbHRlclRhYmxlU3RhdGVtZW50Q29udGV4dC5qYXZh) | `83.78% <0.00%> (-13.10%)` | :arrow_down: |
| [...inder/statement/ddl/DropIndexStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RkbC9Ecm9wSW5kZXhTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...der/statement/ddl/CreateIndexStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RkbC9DcmVhdGVJbmRleFN0YXRlbWVudENvbnRleHQuamF2YQ==) | `80.00% <0.00%> (-8.89%)` | :arrow_down: |
| [...ntracing/service/OpenTracingPluginBootService.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLW9wZW50cmFjaW5nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9vcGVudHJhY2luZy9zZXJ2aWNlL09wZW5UcmFjaW5nUGx1Z2luQm9vdFNlcnZpY2UuamF2YQ==) | `61.53% <0.00%> (-7.70%)` | :arrow_down: |
| [...nder/statement/ddl/AlterIndexStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RkbC9BbHRlckluZGV4U3RhdGVtZW50Q29udGV4dC5qYXZh) | `83.33% <0.00%> (-7.58%)` | :arrow_down: |
| ... and [55 more](https://codecov.io/gh/apache/shardingsphere/pull/18394/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [82a4ac0...1ffda15](https://codecov.io/gh/apache/shardingsphere/pull/18394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org