You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/05/26 00:21:17 UTC
Review Request 59586: Added a test for shutting down executors that
re-register.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59586/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.
Repository: mesos
Description
-------
When already (re-)registered executors attempt to re-register,
and the agent does not have the optional reconnect retry enabled,
the agent will shut down the executor.
Diffs
-----
src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df
Diff: https://reviews.apache.org/r/59586/diff/1/
Testing
-------
Ran in repetition.
Thanks,
Benjamin Mahler
Re: Review Request 59586: Added a test for shutting down executors
that re-register.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59586/#review176170
-----------------------------------------------------------
Ship it!
src/tests/slave_tests.cpp
Lines 7069-7074 (patched)
<https://reviews.apache.org/r/59586/#comment249535>
couldn't use any helper here?
- Vinod Kone
On May 26, 2017, 12:21 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59586/
> -----------------------------------------------------------
>
> (Updated May 26, 2017, 12:21 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When already (re-)registered executors attempt to re-register,
> and the agent does not have the optional reconnect retry enabled,
> the agent will shut down the executor.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df
>
>
> Diff: https://reviews.apache.org/r/59586/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition.
>
>
> Thanks,
>
> Benjamin Mahler
>
>