You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "realMartinez (via GitHub)" <gi...@apache.org> on 2023/06/19 12:24:39 UTC
[GitHub] [camel-k] realMartinez opened a new pull request, #4495: feat/coverage report workflow
realMartinez opened a new pull request, #4495:
URL: https://github.com/apache/camel-k/pull/4495
<!-- Description -->
- added a workflow which comments on newly created or updated PRs the change to code coverage those PRs made.
- the messages can be customized depending on whether the code coverage was changed positively, negatively or was unchanged.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] realMartinez commented on pull request #4495: feat/coverage report workflow
Posted by "realMartinez (via GitHub)" <gi...@apache.org>.
realMartinez commented on PR #4495:
URL: https://github.com/apache/camel-k/pull/4495#issuecomment-1597185666
I changed the format, now messages should look like this, for positive code coverage I used the checkmark.
:camel: **Thank You for contributing!** :camel:
**Code Coverage Report** :warning:
- Coverage changed from: **39.2%** -> **39.0%**
- Coverage difference: **-0.2%**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] realMartinez commented on pull request #4495: feat/coverage report workflow
Posted by "realMartinez (via GitHub)" <gi...@apache.org>.
realMartinez commented on PR #4495:
URL: https://github.com/apache/camel-k/pull/4495#issuecomment-1597103747
Comment Example
:camel: **Thank You for contributing!** :camel:
**Code Coverage Report**
- Coverage changed from: **39.0%** -> **39.2%**
- Coverage difference: **+0.2%**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4495: feat/coverage report workflow
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4495:
URL: https://github.com/apache/camel-k/pull/4495#issuecomment-1598299520
Great stuff. Question, why the coverage action is failing? It seems it fails with a 403, maybe some permission issue? also, I guess that this very same PR should have the new bot comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4495: feat/coverage report workflow
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4495:
URL: https://github.com/apache/camel-k/pull/4495#issuecomment-1611403631
No need to run all checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on pull request #4495: feat/coverage report workflow
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4495:
URL: https://github.com/apache/camel-k/pull/4495#issuecomment-1597163702
That's very nice !
I love the camel icons :+1: . Would it be difficult to have some icon like with a :heavy_check_mark: coverage difference >= 0 and maybe some :warning: for coverage difference < 0 ?
It could be in the title:
**Code Coverage Report :heavy_check_mark:**
**Code Coverage Report :warning:**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #4495: feat/coverage report workflow
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4495:
URL: https://github.com/apache/camel-k/pull/4495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] realMartinez commented on pull request #4495: feat/coverage report workflow
Posted by "realMartinez (via GitHub)" <gi...@apache.org>.
realMartinez commented on PR #4495:
URL: https://github.com/apache/camel-k/pull/4495#issuecomment-1597170509
Not at all, as long as it is supported by markdown it should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] realMartinez commented on pull request #4495: feat/coverage report workflow
Posted by "realMartinez (via GitHub)" <gi...@apache.org>.
realMartinez commented on PR #4495:
URL: https://github.com/apache/camel-k/pull/4495#issuecomment-1598301229
Yeah I looked into it and it seems to be a permission issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org