You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Chris Lombardi (JIRA)" <ji...@apache.org> on 2007/12/06 18:43:43 UTC
[jira] Created: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Aggregate items base price is displayed yet unattainable
--------------------------------------------------------
Key: OFBIZ-1495
URL: https://issues.apache.org/jira/browse/OFBIZ-1495
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: SVN trunk
Reporter: Chris Lombardi
Priority: Minor
I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
Configurable PC
PC001 Your Price: $50.00
Hey, 50$ for a PC, I want one! So I click on the item.
Configurable PC
PC001
Product Aggregated Price: $385.00
What?
So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam reassigned OFBIZ-1495:
------------------------------------
Assignee: Bilgin Ibryam
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557667#action_12557667 ]
Jacques Le Roux commented on OFBIZ-1495:
----------------------------------------
Thanks for comment Bilgin,
Actually our comments crossed on the Net. I think It's ok as it is now. If someone wants to enhance he/her should find a sound base to do so now.
Enhancements could be :
as suggested in point A for POS in my comment above, to show dynamically the agreggated price in the item config window.
as suggested in point B in my comment above, to show the base price.
as suggested in point C in my comment above, to show items prices.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554594 ]
Jacques Le Roux commented on OFBIZ-1495:
----------------------------------------
I put in the enchiladas example as a simple aggregated product of type Food in revision: 607090
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554355 ]
Jacques Le Roux commented on OFBIZ-1495:
----------------------------------------
It's ok for me : +1
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556078#action_12556078 ]
Jacques Le Roux commented on OFBIZ-1495:
----------------------------------------
Chris,
I agree with your prices list. I did not look in details yet (notably the unattainable base price and its consequences) .
Note that there is a concurrent but not totally related effort : OFBIZ-1453
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554447 ]
Chris Lombardi commented on OFBIZ-1495:
---------------------------------------
JLR: Actually, in the ecommerce app, it shows the total price in the shopping cart, but no components pricing. When you go to add an item, it shows the default price for the item and the offset pricing for components. When an aggregate item is displayed in a list (catalog view) it shows only the base price of the item.
I'm not sure what you are proposing for where.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556171#action_12556171 ]
Chris Lombardi commented on OFBIZ-1495:
---------------------------------------
Yes, I have been watching OFBIZ-1453 with interest. I approve of the issue and implementation and didn't have anything to add, so I haven't been involved.
The thing I have been thinking about is that there's some assumptions to be made here for pricing and the type of question. I.e. multiselect questions should display the absolute price. I'm also trying to work over some other scenarios. I'll clean up what I have an submit a patch tomorrow.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554807 ]
Chris Lombardi commented on OFBIZ-1495:
---------------------------------------
Excellent writeup. I had no idea this would touch so many areas.
I can add some methods to ProductConfigWrapper to help push more component logic away from the presentation layer. If I understand this properly, there are four ways to show the pricing of an aggregated item.
i) Total price only
ii) Default price only
iii) Unattainable base price
iv) True base pricing with component detail (base price shown is unattainable)
v) Default price and offset component pricing (component prices are shown relative to the *selected* option)
Are these the only ways we anticipate showing aggregate item pricing, or am I missing something?
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557650#action_12557650 ]
Bilgin Ibryam commented on OFBIZ-1495:
--------------------------------------
I just checked ofbiz-1495.patch and it looks ok.
It does not solve the issue totally as Chris already said and it is mostly an enhancement and base for OFBIZ-1562.
About OFBIZ-1562 and this issue, I am not sure what kind of price offsetting is better to display, but i think, both web UI and pos UI should use the same price offsetting.
My 2 cents
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554400 ]
Bilgin Ibryam commented on OFBIZ-1495:
--------------------------------------
Chris,
even you did not mention it in the beginning, i knew that you will need it also for POS ;)
I also wanted to get the total price from calculateProductPrice service (PriceServices.java) but it looked to me more complicated because:
to get the total price from calculateProductPrice service, i had to create configWrapper object there, but configWrapper constructor also calls calculateProductPrice service...
Now i wonder where in POS you want to display the total price?
If you have configWrapper object, isnt it easier to call configWrapper.getTotalPrice() and to display the total price?
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557257#action_12557257 ]
Bilgin Ibryam commented on OFBIZ-1495:
--------------------------------------
Jacques, thank you for taking care of this issue!
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1495:
----------------------------------
Attachment: ofbiz-1495.patch
Updated to support offset pricing per my earlier post, with one difference. The offset is relative to the default option, not the selected option.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549805 ]
Chris Lombardi commented on OFBIZ-1495:
---------------------------------------
>From OFBIZ-1109
--------------------------------------------------------------------------
Jacques Le Roux - 08/Dec/07 04:41 PM
Actually the only weird thing is the price of the unconfigured product and I agree that we should better show the price of the default configuration. I never occured to me that there was a problem here has I saw the $ 50 as the price without any options. But as it's something you can't reasonnably buy (like a car without tyres or something) showing the default configuration price should be good. Mmmm... I remember now that you have opened an issue to allow a default configuration, I understand why now :o)
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Priority: Minor
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1495) Aggregate items base price is displayed
yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1495.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Chris,
Your patch is in trunk revision: 610796
Bilgin,
I have used your patch has a base to extend for Quick Add, Last Products and Quick Reorder. I also fixed some potential issues in order. It's commited in trunk revision: 610800
Thanks to both of you !
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554577 ]
Jacques Le Roux commented on OFBIZ-1495:
----------------------------------------
Yes you are right Chris. We need before to clarify what we want to see where. There is also still a case where you see only the product base price ($ 50 for a PC001) : Last Products boxe in eCommerce. I forgot that one and we have to do something there to keep consistency.
We should 1st define what we need where, and then see how to do it. The more informations we give the better.
A) I propose to show the Product Aggregated Price everywhere, ie
- eCommerce
. Products list (where you choose to add a product)
. Products details (where you choose to add/modify items)
. Shopping cart view (where you check your choices during shopping)
. Déjà vu list (aka Last Products boxe).
. Final Checkout Review (where you check your choices before payment)
. Order Confirmation (where you check your payment)
For that point to be achieved we need only to show the Product Aggregated Price in déjà vu list in place of the product base price currently shown (this should have been done in your patch I commited recently, so we are both to blame ;o)
- Order Manager
. Nothing to change (it behaves like eCommerce except that there is no Déjà vu list)
- POS
. Item configuration window (where you choose to add an item)
. Journal (where you check choices)
. Receipt (where you check payment)
For that point to be achieved we need to show the Product Aggregated Price in Item configuration window. Maybe we can stay as is.
Below I will not repeat views where a price is already shown (ie no add/changes needed).
B) I propose to show the product base price in
- eCommerce
. Products list
. Products details
. Shopping cart view
For that point to be achieved we need to show the product base price in three views
- POS
. Item configuration window
. Journal
. Receipt
For that point to be achieved we need to show the product base price in three views. Maybe we can let Item configuration window as is.
C) I propose to show items prices in
- eCommerce
. Products list
. Shopping cart view
For that point to be achieved we need to show default items prices in both views
- POS
. Item configuration window
For that point to be achieved we need to show items prices in Item configuration window. Maybe we can stay as is.
Something to note : there is one drawback in my proposition but this is already existing.
. Order view (eCommerce, Order Manager, etc.) is comparable to POS Journal but in Order view you don't have the details of the aggregated item.
. Invoice is comparable to POS Receipt but in Invoice you don't have the details of the aggregated item.
* There is currently a bug in trunk when rendering an invoice PDF, I have opened a new Jira issue for this OFBIZ-1549
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1495:
----------------------------------
Attachment: (was: ofbiz-1495.patch)
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554358 ]
Chris Lombardi commented on OFBIZ-1495:
---------------------------------------
This was taking me a while because I was thinking about how to implement it. The patch addresses the display issue in the web application, but doesn't address my issue of how to handle the default price in the POS application. I had done some digging and found PriceServices.java in production\applications\product\src\org\ofbiz\product\price and thought that might be a place to handle it once instead of implementing it everywhere the price is displayed.
Comments anyone?
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1495:
----------------------------------
Attachment: ofbiz-1495.patch
Added code to keep the default price in the ProductConfigWrapper
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554556 ]
Bilgin Ibryam commented on OFBIZ-1495:
--------------------------------------
Chris,
I like your idea. I would love to have more possibilities/functionality in configurable products.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-1495:
--------------------------------------
Assignee: Jacques Le Roux (was: Bilgin Ibryam)
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554921 ]
Jacques Le Roux commented on OFBIZ-1495:
----------------------------------------
I'm away till thursday, I will have a look then...
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554423 ]
Jacques Le Roux commented on OFBIZ-1495:
----------------------------------------
Actually we have the same information in Web UIs and POS (total price with components prices) but we don't have anymore the base price. I think we only need to show the base price and it should be ok for now. WDYT ?
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1495:
---------------------------------
Attachment: totalPrice.patch
Is this patch ok for the issue?
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1495) Aggregate items base
price is displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554447 ]
clearchris edited comment on OFBIZ-1495 at 12/26/07 12:44 PM:
------------------------------------------------------------------
JLR: Actually, in the ecommerce app, it shows the total price in the shopping cart, but no components pricing. When you go to add an item, it shows the default price for the item and the offset pricing for components. When an aggregate item is displayed in a list (catalog view) it shows only the base price of the item.
I'm not sure what you are proposing for where.
Edit: Sorry, upon re-reading this, that sounded harsh. I didn't mean it to be.
was (Author: clearchris):
JLR: Actually, in the ecommerce app, it shows the total price in the shopping cart, but no components pricing. When you go to add an item, it shows the default price for the item and the offset pricing for components. When an aggregate item is displayed in a list (catalog view) it shows only the base price of the item.
I'm not sure what you are proposing for where.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554388 ]
Jacques Le Roux commented on OFBIZ-1495:
----------------------------------------
Actually the patch addresses also the order manager UI. So it seems that only the POS application is missing. But yes you are right using production\applications\product\src\org\ofbiz\product\price would address all potential issues.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554463 ]
Chris Lombardi commented on OFBIZ-1495:
---------------------------------------
Here's a tweak to ProductConfigWrapper. Does anyone have any thoughts on putting the default price logic here? I can tweak BI's patch to include the new methods if desired as the patches are complementary and not mutually exclusive.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: ofbiz-1495.patch, totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1495) Aggregate items base price is
displayed yet unattainable
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554443 ]
Chris Lombardi commented on OFBIZ-1495:
---------------------------------------
I want to display the price on the journal and the receipts. But I want to use "offset pricing", i.e. show the default price for the main product, and then show the difference in price for options that are not the default.
Let's use a tex-mex example.
Cheese enchiladas 6$
add jalapenos .75$
substitute fajita beef 2$
where "fajita beef" is 4$, but "cheese" is 2$ and default, so the beef shows up as 2$. The price of cheese was already in the "cheese enchiladas". Jalapenos or other peppers aren't included normally, so the full price of .75 shows up.
The problem becomes that once you change the configuration, you lose the default price and have to get a new configwrapper each time.
Now that I'm thinking more about this, maybe just giving the configwrapper a memory of the default configuration price might work. That would allow the POS to use offset pricing (IIRC) and also allow it in the ecommerce shopping cart, if desired.
> Aggregate items base price is displayed yet unattainable
> --------------------------------------------------------
>
> Key: OFBIZ-1495
> URL: https://issues.apache.org/jira/browse/OFBIZ-1495
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Bilgin Ibryam
> Priority: Minor
> Attachments: totalPrice.patch
>
>
> I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
> Configurable PC
> PC001 Your Price: $50.00
> Hey, 50$ for a PC, I want one! So I click on the item.
> Configurable PC
> PC001
> Product Aggregated Price: $385.00
> What?
> So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.