[GitHub] [airflow] nathadfield commented on issue #18053: `VaultHook` AppRole authentication fails when using a conn_uri

[GitBox <gi...@apache.org>]

nathadfield commented on issue #18053:
URL: https://github.com/apache/airflow/issues/18053#issuecomment-914350909


   I think it should be as simple as changing [this](https://github.com/apache/airflow/blob/main/airflow/providers/hashicorp/hooks/vault.py#L151) to this:
   
   ```
   if auth_type in ["approle", "aws_iam"]:
       if not role_id:
           if self.connection.login:
               role_id = self.connection.login
           else:
               role_id = self.connection.extra_dejson.get('role_id')
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org