You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/04/06 14:52:31 UTC
[GitHub] [jackrabbit-oak] stefan-egli opened a new pull request #282: OAK-9176 : backport from trunk to 1.22 branch
stefan-egli opened a new pull request #282:
URL: https://github.com/apache/jackrabbit-oak/pull/282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg commented on pull request #282: OAK-9176 : backport from trunk to 1.22 branch
Posted by GitBox <gi...@apache.org>.
mreutegg commented on pull request #282:
URL: https://github.com/apache/jackrabbit-oak/pull/282#issuecomment-814230387
Compared the commit on trunk (https://github.com/apache/jackrabbit-oak/commit/db584aa52b8e8b7351d40d1fac5de1e3bad43aff.patch) with the one on this branch (https://github.com/apache/jackrabbit-oak/commit/db584aa52b8e8b7351d40d1fac5de1e3bad43aff.patch) and it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] stefan-egli commented on a change in pull request #282: OAK-9176 : backport from trunk to 1.22 branch
Posted by GitBox <gi...@apache.org>.
stefan-egli commented on a change in pull request #282:
URL: https://github.com/apache/jackrabbit-oak/pull/282#discussion_r607963574
##########
File path: RELEASE-NOTES.txt
##########
@@ -25,6 +25,8 @@ Bug
Improvement
[OAK-9261] - Upgrade Apache Solr to 8.6.3 and remove Embedded Solr Server
+ [OAK-9176] - Fix for sweep missing _bc (branch commit) entries in some cases - plus sweep2 introduced to clean up repository accordingly.
+ PS: use -Doak.documentMK.disableSweep2=true to disable sweep2 in case it should be skipped explicitly
Review comment:
PS: There's also details in the [upgrade page](https://jackrabbit.apache.org/oak/docs/nodestore/document/upgrade.html)..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] stefan-egli closed pull request #282: OAK-9176 : backport from trunk to 1.22 branch
Posted by GitBox <gi...@apache.org>.
stefan-egli closed pull request #282:
URL: https://github.com/apache/jackrabbit-oak/pull/282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #282: OAK-9176 : backport from trunk to 1.22 branch
Posted by GitBox <gi...@apache.org>.
stefan-egli commented on pull request #282:
URL: https://github.com/apache/jackrabbit-oak/pull/282#issuecomment-814186576
Note that the commits before
```
OAK-9134 related : removed unused imports
```
were just branch-merge-yoga and do not contain any diff (except this particular unused import)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg commented on a change in pull request #282: OAK-9176 : backport from trunk to 1.22 branch
Posted by GitBox <gi...@apache.org>.
mreutegg commented on a change in pull request #282:
URL: https://github.com/apache/jackrabbit-oak/pull/282#discussion_r607958018
##########
File path: RELEASE-NOTES.txt
##########
@@ -25,6 +25,8 @@ Bug
Improvement
[OAK-9261] - Upgrade Apache Solr to 8.6.3 and remove Embedded Solr Server
+ [OAK-9176] - Fix for sweep missing _bc (branch commit) entries in some cases - plus sweep2 introduced to clean up repository accordingly.
+ PS: use -Doak.documentMK.disableSweep2=true to disable sweep2 in case it should be skipped explicitly
Review comment:
This is usually done by the person who creates the release based on information in JIRA.
I think it would be better if additional information is added further up in the release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #282: OAK-9176 : backport from trunk to 1.22 branch
Posted by GitBox <gi...@apache.org>.
stefan-egli commented on pull request #282:
URL: https://github.com/apache/jackrabbit-oak/pull/282#issuecomment-814252820
Thx, I'll merge the PR to svn next
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #282: OAK-9176 : backport from trunk to 1.22 branch
Posted by GitBox <gi...@apache.org>.
stefan-egli commented on pull request #282:
URL: https://github.com/apache/jackrabbit-oak/pull/282#issuecomment-814288671
Merged to svn in rev 1888445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org