[GitHub] [arrow] amol- commented on a change in pull request #12765: ARROW-15523: [Python] Support for Datasets as inputs of Joins

[GitBox <gi...@apache.org>]

amol- commented on a change in pull request #12765:
URL: https://github.com/apache/arrow/pull/12765#discussion_r839712011



##########
File path: python/pyarrow/_exec_plan.pyx
##########
@@ -81,21 +93,31 @@ cdef execplan(inputs, output_type, vector[CDeclaration] plan, c_bool use_threads
     # Create source nodes for each input
     for ipt in inputs:
         if isinstance(ipt, Table):
+            node_factory = "source"
             c_in_table = pyarrow_unwrap_table(ipt).get()
             c_sourceopts = GetResultValue(
                 CSourceNodeOptions.FromTable(deref(c_in_table), deref(c_exec_context).executor()))
+            c_input_node_opts.swap(deref(<shared_ptr[CExecNodeOptions]*>&c_sourceopts))

Review comment:
       This casting dance (both here in in the `else:` branch) is to make Cython happy, as it doesn't support upcasting `shared_ptr<CSourceNodeOptions>` to `shared_ptr<CExecNodeOptions>`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org