You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by dk...@apache.org on 2018/05/22 17:01:02 UTC
[sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
This is an automated email from the ASF dual-hosted git repository.
dklco pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-site.git
The following commit(s) were added to refs/heads/master by this push:
new d94aef4 Re-adding launchpad content since though it's deprecated, it still may need to be available to download
d94aef4 is described below
commit d94aef441bf10e047f5af0038538e0dde1c92082
Author: Dan Klco <kl...@users.noreply.github.com>
AuthorDate: Tue May 22 13:00:59 2018 -0400
Re-adding launchpad content since though it's deprecated, it still may need to be available to download
---
src/main/jbake/templates/downloads.tpl | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/main/jbake/templates/downloads.tpl b/src/main/jbake/templates/downloads.tpl
index 535f7b5..e20854c 100644
--- a/src/main/jbake/templates/downloads.tpl
+++ b/src/main/jbake/templates/downloads.tpl
@@ -151,6 +151,7 @@ def bundles=[
"Launchpad Base|org.apache.sling.launchpad.base|5.6.10-2.6.26",
"Launchpad Base - Application Launcher|org.apache.sling.launchpad.base|5.6.10-2.6.26|app",
"Launchpad Base - Web Launcher|org.apache.sling.launchpad.base|5.6.10-2.6.26|webapp|war",
+ "Launchpad Content|org.apache.sling.launchpad.content|2.0.12",
"Launchpad Installer|org.apache.sling.launchpad.installer|1.2.2",
"Launchpad Integration Tests|org.apache.sling.launchpad.integration-tests|1.0.6",
"Launchpad Test Fragment Bundle|org.apache.sling.launchpad.test-fragment|2.0.14",
--
To stop receiving notification emails like this one, please contact
dklco@apache.org.
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Daniel Klco <da...@gmail.com>.
Robert,
Absolutely, I agree and I think this makes sense with what Jason Bailey
brought up with creating a separate list of the deprecated downloads.
Regards,
Dan
On Wed, May 23, 2018 at 3:34 AM, Robert Munteanu <ro...@apache.org> wrote:
> Hi Dan,
>
>
>
> On Tue, 2018-05-22 at 17:01 +0000, dklco@apache.org wrote:
> > commit d94aef441bf10e047f5af0038538e0dde1c92082
> > Author: Dan Klco <kl...@users.noreply.github.com>
> > AuthorDate: Tue May 22 13:00:59 2018 -0400
> >
> > Re-adding launchpad content since though it's deprecated, it
> > still may need to be available to download
>
> That's a very good idea. Would it make sense to add "(Deprecated)" or
> "(replaced by ...)" next to this entry?
>
> Robert
>
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2018-05-23 at 15:57 +0200, Bertrand Delacretaz wrote:
> On Wed, May 23, 2018 at 9:34 AM, Robert Munteanu <ro...@apache.org>
> wrote:
> > ...That's a very good idea. Would it make sense to add
> > "(Deprecated)" or
> > "(replaced by ...)" next to this entry?...
>
> Or add a deprecation badge at [1] ?
I think we can do both. This way, we cover all access paths.
Robert
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, May 23, 2018 at 5:56 PM, Daniel Klco <da...@gmail.com> wrote:
> ...Shields.io seems to be a pretty common standard for GitHub projects so what
> if we just use these rather than self-hosting?...
Why not, especially if you need dynamic badges.
> Ideally, it'd be great to update our README like this one:
> https://github.com/klcodanr/sling-org-apache-sling-auth-form
+1
-Bertrand
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Daniel Klco <dk...@apache.org>.
I took a bit of time this morning to look through this and I think I've got
a pretty slick script to run through and add all of these badges. The nice
thing is that it supports running single projects and overwriting so we can
pretty easily update a project if it later added builds, tests or coverage.
This will automatically add badges for:
- Contrib (if applicable, currently all of the projects that in SVN were
in the contrib folder)
- Deprecated (not really applicable ATM, but we could add more in the
CSV, this same CSV could be used to drive the deprecated lists in downloads)
- Apache 2 License (always)
- Maven Release (if code released to maven)
- Jenkins Tests (if tests are configured in Jenkins)
- Jenkins Test Coverage (if coverage is configured in Jenkins)
- Jenkins Build status (if the project is build in jenkins)
- the apache sling logo (always)
The script also presents a preview of the rendered README and will prompt
for the next action, (e.g. commit, don't commit or revert changes).
If others could take a look at this script over the next couple days I'd
like a sanity check, but if there are no objections I'll run it Friday, 8
June 2018.
-Dan
On Fri, May 25, 2018 at 10:28 AM, Daniel Klco <dk...@apache.org> wrote:
> Good point, I ran a script against the SVN repo and got this:
>
> https://issues.apache.org/jira/secure/attachment/12925152/Sling-Repos.csv
>
> The script also checked for a GitHub repo so we can see which modules were
> not migrated over (there are some false negatives) but it should be a good
> starting point for a deprecated / contrib list.
>
> I've created an issue to track this work and am going to start working on
> the list of repos and a script to update them:
> https://issues.apache.org/jira/browse/SLING-7684
>
> Regards,
> Dan
>
> On Fri, May 25, 2018 at 4:05 AM, Bertrand Delacretaz <
> bdelacretaz@apache.org> wrote:
>
>> On Thu, May 24, 2018 at 4:53 PM, Daniel Klco <da...@gmail.com>
>> wrote:
>> > ...Is there a list of the deprecated / contrib
>> > repositories?...
>>
>> Not that I know, but we might rebuild (most of) that from the old svn
>> structure.
>>
>> I won't have time to work on this in the next ten days but interested
>> in helping make the whole badges thing happen.
>>
>> -Bertrand
>>
>
>
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Daniel Klco <dk...@apache.org>.
Good point, I ran a script against the SVN repo and got this:
https://issues.apache.org/jira/secure/attachment/12925152/Sling-Repos.csv
The script also checked for a GitHub repo so we can see which modules were
not migrated over (there are some false negatives) but it should be a good
starting point for a deprecated / contrib list.
I've created an issue to track this work and am going to start working on
the list of repos and a script to update them:
https://issues.apache.org/jira/browse/SLING-7684
Regards,
Dan
On Fri, May 25, 2018 at 4:05 AM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> On Thu, May 24, 2018 at 4:53 PM, Daniel Klco <da...@gmail.com>
> wrote:
> > ...Is there a list of the deprecated / contrib
> > repositories?...
>
> Not that I know, but we might rebuild (most of) that from the old svn
> structure.
>
> I won't have time to work on this in the next ten days but interested
> in helping make the whole badges thing happen.
>
> -Bertrand
>
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Thu, May 24, 2018 at 4:53 PM, Daniel Klco <da...@gmail.com> wrote:
> ...Is there a list of the deprecated / contrib
> repositories?...
Not that I know, but we might rebuild (most of) that from the old svn structure.
I won't have time to work on this in the next ten days but interested
in helping make the whole badges thing happen.
-Bertrand
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Daniel Klco <da...@gmail.com>.
Seems sensible to me. Is there a list of the deprecated / contrib
repositories? I just pushed in the change, but haven't updated the site
since there are new releases which may not have propagated.
On Thu, May 24, 2018 at 4:20 AM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> On Wed, May 23, 2018 at 5:56 PM, Daniel Klco <da...@gmail.com>
> wrote:
> > ...Shields.io seems to be a pretty common standard for GitHub projects
> so what
> > if we just use these rather than self-hosting?...
>
> Thinking about it, I suggest using both self-hosted and dynamic
> badges, for different purposes:
>
> a) Self-hosted SVG badges under http://sling.apache.org/res/badges for
> static repository attributes like deprecated, contrib etc.
>
> AFAIK we can copy badges generated at http://shields.io/ there, that
> website doesn't seem to have any usage restrictions.
>
> Having well-known URLs that we control for those makes sure they are
> consistent and allows us to detect them in scripts. The
> http://sling.apache.org/repolist.html page for example can be improved
> to include the badges by parsing the modules README files for badges
> based on those well-known URLs. And the downloads page could also use
> that maybe instead of duplicating information by splitting modules in
> lists.
>
> b) Dynamic badges for build results etc., things that are not static
> attributes of the code repositories
>
> WDYT?
>
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, May 23, 2018 at 5:56 PM, Daniel Klco <da...@gmail.com> wrote:
> ...Shields.io seems to be a pretty common standard for GitHub projects so what
> if we just use these rather than self-hosting?...
Thinking about it, I suggest using both self-hosted and dynamic
badges, for different purposes:
a) Self-hosted SVG badges under http://sling.apache.org/res/badges for
static repository attributes like deprecated, contrib etc.
AFAIK we can copy badges generated at http://shields.io/ there, that
website doesn't seem to have any usage restrictions.
Having well-known URLs that we control for those makes sure they are
consistent and allows us to detect them in scripts. The
http://sling.apache.org/repolist.html page for example can be improved
to include the badges by parsing the modules README files for badges
based on those well-known URLs. And the downloads page could also use
that maybe instead of duplicating information by splitting modules in
lists.
b) Dynamic badges for build results etc., things that are not static
attributes of the code repositories
WDYT?
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Daniel Klco <da...@gmail.com>.
How do these icons work:
deprecated -> https://img.shields.io/badge/style-deprecated-lightgrey.
svg?longCache=true&style=cool&label=Status
contrib -> https://img.shields.io/badge/style-contrib-green.svg?
longCache=true&style=cool&label=Status
It'd be great if we could also add some dynamic badges:
jenkins build ->
https://img.shields.io/jenkins/s/https/builds.apache.org/view/S-Z/view/Sling/job/sling-org-apache-sling-auth-form-1.8.svg
jenkins test ->
https://img.shields.io/jenkins/t/https/builds.apache.org/view/S-Z/view/Sling/job/sling-org-apache-sling-auth-form-1.8.svg
Shields.io seems to be a pretty common standard for GitHub projects so what
if we just use these rather than self-hosting?
Ideally, it'd be great to update our README like this one:
https://github.com/klcodanr/sling-org-apache-sling-auth-form
On Wed, May 23, 2018 at 10:54 AM, Bertrand Delacretaz <
bdelacretaz@apache.org> wrote:
> On Wed, May 23, 2018 at 4:19 PM, Daniel Klco <dk...@apache.org> wrote:
> > ...How does this look for a deprecation list on the downloads page:
> >
> > https://imgur.com/a/dYxXKp7
> >
> > Does deprecated seem like the right term? Or obsolete?...
>
> Deprecated works for me.
>
> -Bertrand
>
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, May 23, 2018 at 4:19 PM, Daniel Klco <dk...@apache.org> wrote:
> ...How does this look for a deprecation list on the downloads page:
>
> https://imgur.com/a/dYxXKp7
>
> Does deprecated seem like the right term? Or obsolete?...
Deprecated works for me.
-Bertrand
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2018-05-23 at 10:19 -0400, Daniel Klco wrote:
> How does this look for a deprecation list on the downloads page:
>
> https://imgur.com/a/dYxXKp7
+1
> Does deprecated seem like the right term? Or obsolete?
Deprecated works for me.
Robert
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Daniel Klco <da...@gmail.com>.
I added the list in, but I'm not 100% sure what all should be included.
There are a number of repositories in GitHub which haven't been touched
since they were migrated, but that could just be modules that are very
basic / stable:
https://github.com/search?p=25&q=user%3Aapache+sling&s=updated&type=Repositories&utf8=%E2%9C%93
On Wed, May 23, 2018 at 4:59 PM, Jason E Bailey <je...@apache.org> wrote:
> The deprecated list is what I was looking at doing. You got that? Or
> should I?
>
> - Jason
>
> On Wed, May 23, 2018, at 10:19 AM, Daniel Klco wrote:
> > I'd be inclined to update the downloads page AND add a depreciation
> badge.
> > IMO these are two different use cases, people visiting the downloads site
> > are looking for a bundle to install into their Sling instance whereas
> > people looking at the Github site are looking for the code / to
> contribute.
> > We should inform them in both cases.
> >
> > How does this look for a deprecation list on the downloads page:
> >
> > https://imgur.com/a/dYxXKp7
> >
> > Does deprecated seem like the right term? Or obsolete?
> >
> > On Wed, May 23, 2018 at 9:57 AM, Bertrand Delacretaz <
> bdelacretaz@apache.org
> > > wrote:
> >
> > > On Wed, May 23, 2018 at 9:34 AM, Robert Munteanu <ro...@apache.org>
> > > wrote:
> > > > ...That's a very good idea. Would it make sense to add
> "(Deprecated)" or
> > > > "(replaced by ...)" next to this entry?...
> > >
> > > Or add a deprecation badge at [1] ?
> > >
> > > I meant to use GitHub Topics for such things but we're not allowed to
> > > change them, so we might define a few badges for "contrib",
> > > "deprecated" etc. instead. and add them at the top of READMEs.
> > >
> > > I'm thinking of badges like the "contrib" one that I tried at
> > > https://github.com/apache/sling-org-apache-sling-
> launchpad-contrib-testing
> > > .
> > > We might store such badges as svg files under
> > > http://sling.apache.org/badges and refer to them from README files.
> > >
> > > -Bertrand
> > >
> > > [1] https://github.com/apache/sling-org-apache-sling-starter-content
> > >
>
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated,
it still may need to be available to download
Posted by Jason E Bailey <je...@apache.org>.
The deprecated list is what I was looking at doing. You got that? Or should I?
- Jason
On Wed, May 23, 2018, at 10:19 AM, Daniel Klco wrote:
> I'd be inclined to update the downloads page AND add a depreciation badge.
> IMO these are two different use cases, people visiting the downloads site
> are looking for a bundle to install into their Sling instance whereas
> people looking at the Github site are looking for the code / to contribute.
> We should inform them in both cases.
>
> How does this look for a deprecation list on the downloads page:
>
> https://imgur.com/a/dYxXKp7
>
> Does deprecated seem like the right term? Or obsolete?
>
> On Wed, May 23, 2018 at 9:57 AM, Bertrand Delacretaz <bdelacretaz@apache.org
> > wrote:
>
> > On Wed, May 23, 2018 at 9:34 AM, Robert Munteanu <ro...@apache.org>
> > wrote:
> > > ...That's a very good idea. Would it make sense to add "(Deprecated)" or
> > > "(replaced by ...)" next to this entry?...
> >
> > Or add a deprecation badge at [1] ?
> >
> > I meant to use GitHub Topics for such things but we're not allowed to
> > change them, so we might define a few badges for "contrib",
> > "deprecated" etc. instead. and add them at the top of READMEs.
> >
> > I'm thinking of badges like the "contrib" one that I tried at
> > https://github.com/apache/sling-org-apache-sling-launchpad-contrib-testing
> > .
> > We might store such badges as svg files under
> > http://sling.apache.org/badges and refer to them from README files.
> >
> > -Bertrand
> >
> > [1] https://github.com/apache/sling-org-apache-sling-starter-content
> >
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Daniel Klco <dk...@apache.org>.
I'd be inclined to update the downloads page AND add a depreciation badge.
IMO these are two different use cases, people visiting the downloads site
are looking for a bundle to install into their Sling instance whereas
people looking at the Github site are looking for the code / to contribute.
We should inform them in both cases.
How does this look for a deprecation list on the downloads page:
https://imgur.com/a/dYxXKp7
Does deprecated seem like the right term? Or obsolete?
On Wed, May 23, 2018 at 9:57 AM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:
> On Wed, May 23, 2018 at 9:34 AM, Robert Munteanu <ro...@apache.org>
> wrote:
> > ...That's a very good idea. Would it make sense to add "(Deprecated)" or
> > "(replaced by ...)" next to this entry?...
>
> Or add a deprecation badge at [1] ?
>
> I meant to use GitHub Topics for such things but we're not allowed to
> change them, so we might define a few badges for "contrib",
> "deprecated" etc. instead. and add them at the top of READMEs.
>
> I'm thinking of badges like the "contrib" one that I tried at
> https://github.com/apache/sling-org-apache-sling-launchpad-contrib-testing
> .
> We might store such badges as svg files under
> http://sling.apache.org/badges and refer to them from README files.
>
> -Bertrand
>
> [1] https://github.com/apache/sling-org-apache-sling-starter-content
>
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, May 23, 2018 at 9:34 AM, Robert Munteanu <ro...@apache.org> wrote:
> ...That's a very good idea. Would it make sense to add "(Deprecated)" or
> "(replaced by ...)" next to this entry?...
Or add a deprecation badge at [1] ?
I meant to use GitHub Topics for such things but we're not allowed to
change them, so we might define a few badges for "contrib",
"deprecated" etc. instead. and add them at the top of READMEs.
I'm thinking of badges like the "contrib" one that I tried at
https://github.com/apache/sling-org-apache-sling-launchpad-contrib-testing.
We might store such badges as svg files under
http://sling.apache.org/badges and refer to them from README files.
-Bertrand
[1] https://github.com/apache/sling-org-apache-sling-starter-content
Re: [sling-site] branch master updated: Re-adding launchpad content
since though it's deprecated, it still may need to be available to download
Posted by Robert Munteanu <ro...@apache.org>.
Hi Dan,
On Tue, 2018-05-22 at 17:01 +0000, dklco@apache.org wrote:
> commit d94aef441bf10e047f5af0038538e0dde1c92082
> Author: Dan Klco <kl...@users.noreply.github.com>
> AuthorDate: Tue May 22 13:00:59 2018 -0400
>
> Re-adding launchpad content since though it's deprecated, it
> still may need to be available to download
That's a very good idea. Would it make sense to add "(Deprecated)" or
"(replaced by ...)" next to this entry?
Robert