You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/12/02 03:03:19 UTC
[kudu-CR](branch-1.6.x) consensus: Make queue more debuggable
Hello Kudu Jenkins, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8724
to review the following change.
Change subject: consensus: Make queue more debuggable
......................................................................
consensus: Make queue more debuggable
After the introduction of SafeToEvict() logic in the consensus queue,
the eviction criteria has become more subtle. It would be helpful to get
more information about the state of the leader queue from the web UI to
aid in troubleshooting. This patch dumps the queue information in the
web UI and also includes the time since last communication with each
peer in the per-peer Watermarks table.
Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Reviewed-on: http://gerrit.cloudera.org:8080/8708
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/8724/1
--
To view, visit http://gerrit.cloudera.org:8080/8724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8724
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.6.x) consensus: Make queue more debuggable
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8724 )
Change subject: consensus: Make queue more debuggable
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8724
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 02 Dec 2017 04:02:22 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) consensus: Make queue more debuggable
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8724 )
Change subject: consensus: Make queue more debuggable
......................................................................
consensus: Make queue more debuggable
After the introduction of SafeToEvict() logic in the consensus queue,
the eviction criteria has become more subtle. It would be helpful to get
more information about the state of the leader queue from the web UI to
aid in troubleshooting. This patch dumps the queue information in the
web UI and also includes the time since last communication with each
peer in the per-peer Watermarks table.
Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Reviewed-on: http://gerrit.cloudera.org:8080/8708
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/8724
Tested-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Mike Percy: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8724
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](branch-1.6.x) consensus: Make queue more debuggable
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8724 )
Change subject: consensus: Make queue more debuggable
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8724
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 02 Dec 2017 05:22:06 +0000
Gerrit-HasComments: No