You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/11/13 08:53:11 UTC
[GitHub] [phoenix] luocooong opened a new pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
luocooong opened a new pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350
# [PHOENIX-6582](https://issues.apache.org/jira/browse/PHOENIX-6582): Bump default HBase version to 2.3.7 and 2.4.8
## Description
N/A
## Documentation
N/A
## Testing
Build with the hbase 2.3.7 and 2.4.8, skip the unit tests :
```bash
mvn clean install -DskipTests -Dhbase.profile=2.3 -Dhbase.version=2.3.7
mvn clean install -DskipTests -Dhbase.profile=2.4 -Dhbase.version=2.4.8
```
<pre>
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Phoenix 5.1.3-SNAPSHOT:
[INFO]
[INFO] Apache Phoenix ..................................... SUCCESS [ 3.868 s]
[INFO] Phoenix Hbase 2.4.1 compatibility .................. SUCCESS [ 17.509 s]
[INFO] Phoenix Hbase 2.4.0 compatibility .................. SUCCESS [ 1.541 s]
[INFO] Phoenix Hbase 2.3.0 compatibility .................. SUCCESS [ 1.973 s]
[INFO] Phoenix Hbase 2.2.5 compatibility .................. SUCCESS [ 1.322 s]
[INFO] Phoenix Hbase 2.1.6 compatibility .................. SUCCESS [ 1.180 s]
[INFO] Phoenix Core ....................................... SUCCESS [ 20.284 s]
[INFO] Phoenix - Pherf .................................... SUCCESS [ 9.079 s]
[INFO] Phoenix - Tracing Web Application .................. SUCCESS [ 5.207 s]
[INFO] Phoenix Client Parent .............................. SUCCESS [ 0.029 s]
[INFO] Phoenix Client ..................................... SUCCESS [03:07 min]
[INFO] Phoenix Client Embedded ............................ SUCCESS [03:22 min]
[INFO] Phoenix Server JAR ................................. SUCCESS [ 47.652 s]
[INFO] Phoenix Assembly ................................... SUCCESS [ 13.922 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
</pre>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-991628544
2.4.8 passed with only the usual flakies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-991628544
2.4.8 passed with only the usual flakies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] luocooong commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-989812164
@virajjasani That's how it was! Before that, I was curious about why we separated the different versions to commit. Thanks for your explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] luocooong commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-989783332
@virajjasani Okay. I think I'll try to do that this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-968604857
The test failure is a limitation of the Yetus HBase rebuild logic, which doesn't rebuild the old version.
Please run a full test (dev/rebuild.sh <hbase_version>, then mvn verify -Dhbase.profile=<profile>) with both HBase versions manually, and check the results.
(There are some flaky tests, you may ignore or re-run those)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty edited a comment on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-968604857
The test failure is a limitation of the Yetus HBase rebuild logic, which rebuilds the old version.
Please run a full test (dev/rebuild.sh <hbase_version>, then mvn verify -Dhbase.profile=<profile>) with both HBase versions manually, and check the results.
(There are some flaky tests, you may ignore or re-run those)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-989717436
I have manually triggered the build for this PR. At least we will get test results for 2.4.8 version. @luocooong thanks for your work, if you are planning to include 2.3.7 as well, could you please run `mvn verify` as suggested by @stoty ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-989786663
Thanks @luocooong. Or on the other hand, we can bump 2.3.7 on 2.3 release line as a separate PR and on that PR we will try to run test with 2.3.7 with a temporary commit to change default profile. Once satisfactory QA results are available, we can revert that temp commit and merge the PR.
That way this PR can focus on 2.4.8 alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty edited a comment on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #1350:
URL: https://github.com/apache/phoenix/pull/1350#issuecomment-968604857
The test failure is a limitation of the Yetus HBase rebuild logic, which rebuilds the old version.
Please run a full test `dev/rebuild.sh <hbase_version>, then mvn verify -Dhbase.profile=<profile>` with both HBase versions manually, and check the results.
(There are some flaky tests, you may ignore or re-run those)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org