You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by mi...@apache.org on 2003/04/05 21:48:02 UTC
cvs commit: httpd-2.0/server scoreboard.c
minfrin 2003/04/05 11:48:02
Modified: server Tag: APACHE_2_0_BRANCH scoreboard.c
Log:
- Clarify an error message to be more useful
Revision Changes Path
No revision
No revision
1.68.2.2 +2 -2 httpd-2.0/server/scoreboard.c
Index: scoreboard.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/scoreboard.c,v
retrieving revision 1.68.2.1
retrieving revision 1.68.2.2
diff -u -r1.68.2.1 -r1.68.2.2
--- scoreboard.c 3 Feb 2003 17:32:01 -0000 1.68.2.1
+++ scoreboard.c 5 Apr 2003 19:48:02 -0000 1.68.2.2
@@ -179,8 +179,8 @@
rv = apr_shm_create(&ap_scoreboard_shm, scoreboard_size, fname, pool);
if (rv != APR_SUCCESS) {
ap_log_error(APLOG_MARK, APLOG_CRIT, rv, NULL,
- "unable to create scoreboard "
- "(name-based shared memory failure)");
+ "unable to create scoreboard using filename %s "
+ "(name-based shared memory failure)", fname);
return rv;
}
#endif /* APR_HAS_SHARED_MEMORY */
Re: cvs commit: httpd-2.0/server scoreboard.c
Posted by Graham Leggett <mi...@sharp.fm>.
Jeff Trawick wrote:
> If you'd tried to put this in 2.1-dev first, you'd have noticed that
> Martin coded the same change with slightly different wording 12 days ago.
I did notice - but I left it, as the change was already there. Didn't
think the wording was that important.
I think though that simple changes like this one (clarifying an error
message) should always be made to both v2.0 and v2.1 (unless the code in
each tree is radiacally different). If the fix had been ported to v2.0,
it would have saved me a lot of headaches.
> Can you pick whichever message flavor you like and get them in synch
> pretty please?
Will do.
Regards,
Graham
--
-----------------------------------------
minfrin@sharp.fm "There's a moon
over Bourbon Street
tonight..."
Re: cvs commit: httpd-2.0/server scoreboard.c
Posted by Jeff Trawick <tr...@attglobal.net>.
minfrin@apache.org wrote:
> minfrin 2003/04/05 11:48:02
>
> Modified: server Tag: APACHE_2_0_BRANCH scoreboard.c
> Log:
> - Clarify an error message to be more useful
Graham,
Things need to be in 2.1-dev first, or at least within a very short time
of committing to 2.0.x-dev.
If you'd tried to put this in 2.1-dev first, you'd have noticed that
Martin coded the same change with slightly different wording 12 days ago.
Can you pick whichever message flavor you like and get them in synch
pretty please?
Thanks,
Jeff