You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/09 00:43:14 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39456: [SPARK-41904][CONNECT][PYTHON] Fix Function `nth_value` functions output
HyukjinKwon commented on code in PR #39456:
URL: https://github.com/apache/spark/pull/39456#discussion_r1064229998
##########
python/pyspark/sql/tests/connect/test_parity_functions.py:
##########
@@ -122,8 +122,6 @@ def test_nested_higher_order_function(self):
def test_np_scalar_input(self):
super().test_np_scalar_input()
- # TODO(SPARK-41904): Fix nth_value value
- @unittest.skip("Fails in Spark Connect, should enable.")
def test_nth_value(self):
super().test_nth_value()
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org