You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/13 13:05:42 UTC
[GitHub] [iotdb] xinzhongtianxia opened a new pull request, #6265: [IOTDB-3473][metrics] Prometheus reporter will lose data in some conditions
xinzhongtianxia opened a new pull request, #6265:
URL: https://github.com/apache/iotdb/pull/6265
see https://issues.apache.org/jira/browse/IOTDB-3473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6265: [IOTDB-3473][metrics] Prometheus reporter will lose data in some conditions
Posted by GitBox <gi...@apache.org>.
SpriCoder commented on code in PR #6265:
URL: https://github.com/apache/iotdb/pull/6265#discussion_r895703394
##########
server/src/main/java/org/apache/iotdb/db/service/metrics/recorder/CompactionMetricsRecorder.java:
##########
@@ -144,9 +144,7 @@ public static void recordTaskInfo(
Metric.COST_TASK.toString(),
MetricLevel.IMPORTANT,
Tag.NAME.toString(),
- "compaction",
- Tag.TYPE.toString(),
- isInnerTask ? "inner" : "cross");
+ isInnerTask ? "inner_compaction" : "cross_compaction");
Review Comment:
Please update doc at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xinzhongtianxia commented on a diff in pull request #6265: [IOTDB-3473][metrics] Prometheus reporter will lose data in some conditions
Posted by GitBox <gi...@apache.org>.
xinzhongtianxia commented on code in PR #6265:
URL: https://github.com/apache/iotdb/pull/6265#discussion_r896294458
##########
server/src/main/java/org/apache/iotdb/db/service/metrics/recorder/CompactionMetricsRecorder.java:
##########
@@ -144,9 +144,7 @@ public static void recordTaskInfo(
Metric.COST_TASK.toString(),
MetricLevel.IMPORTANT,
Tag.NAME.toString(),
- "compaction",
- Tag.TYPE.toString(),
- isInnerTask ? "inner" : "cross");
+ isInnerTask ? "inner_compaction" : "cross_compaction");
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #6265: [IOTDB-3473][metrics] Prometheus reporter will lose data in some conditions
Posted by GitBox <gi...@apache.org>.
xingtanzjr merged PR #6265:
URL: https://github.com/apache/iotdb/pull/6265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org