You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/08/02 11:15:09 UTC

[GitHub] [incubator-mxnet] bartekkuncer commented on a diff in pull request #21103: Add support for bool data type for condition in where operator

bartekkuncer commented on code in PR #21103:
URL: https://github.com/apache/incubator-mxnet/pull/21103#discussion_r935438148


##########
src/operator/nn/dnnl/dnnl_where.cc:
##########
@@ -34,7 +34,15 @@ namespace op {
 
 // Support for https://oneapi-src.github.io/oneDNN/v2.6/dev_guide_binary.html
 bool SupportDNNLWhere(const std::vector<NDArray>& inputs) {
-  return SupportDNNL<DNNLTypeMode::NoInt32, DNNLTensorsDtypes::Mixed>(inputs);
+  if (inputs[0].dtype() == mshadow::kBool) {
+    // oneDNN natively doesn't support bool data type, however this operator was written
+    // to allow using bool datatype for 'condition' tensor - data will be treated as uint8

Review Comment:
   data type or datatype?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org