Re: [PR] [SPARK-51773][SQL] Add hashCode and equals to file formats [spark]

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #50562:
URL: https://github.com/apache/spark/pull/50562#discussion_r2041241468


##########
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala:
##########
@@ -49,6 +49,10 @@ private[image] class ImageFileFormat extends FileFormat with DataSourceRegister
 
   override def shortName(): String = "image"
 
+  override def hashCode(): Int = getClass.getCanonicalName.hashCode()
+
+  override def equals(other: Any): Boolean = other.isInstanceOf[ImageFileFormat]

Review Comment:
   Hm, the options can be different. For example, `dropInvalid` can be enabled/disabled, which results in different outputs. Is this safe to assume that they are same?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org