You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/21 15:39:15 UTC

[GitHub] [incubator-nuttx] mrivi opened a new pull request #1623: RTR extension

mrivi opened a new pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623


   ## Summary
   this PR extends the support for RTR also in cases where the extended id is used. 
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1623: RTR extension

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623#issuecomment-680238192


   @davids5 The change was just moving a single `#endif` and the nxstyle issues where somewhere else, I fixed those and pushed.  Could you merge it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1623: RTR extension

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623#issuecomment-680319955


   > @Ouss4 I am sorry I forced pushed over you commits. I didn't realize you made changes
   
   No problem.  I thought the PR was idle.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] mrivi commented on pull request #1623: RTR extension

Posted by GitBox <gi...@apache.org>.
mrivi commented on pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623#issuecomment-680258911


   @Ouss4 I am sorry I forced pushed over you commits. I didn't realize you made changes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 merged pull request #1623: RTR extension

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #1623: RTR extension

Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623#issuecomment-680319955


   > @Ouss4 I am sorry I forced pushed over you commits. I didn't realize you made changes
   
   No problem, your changes take precedence, I thought the PR was idle.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #1623: RTR extension

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1623:
URL: https://github.com/apache/incubator-nuttx/pull/1623#issuecomment-678369922


   @mrivi 
   
   Please run tools nxstyle on the changed file.
   
   If the log lines MUST to be kept intact for readability you can extend the lines of ****, (it is the ruler)
   if not please wrap them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org