You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2013/06/20 06:32:40 UTC

git commit: Disable no-push mode for now since the logic for pushing afterwards is broken.

Updated Branches:
  refs/heads/master f36d09d00 -> 7cf30f1fc


Disable no-push mode for now since the logic for pushing afterwards is broken.

Needs more thought.


Project: http://git-wip-us.apache.org/repos/asf/cordova-coho/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-coho/commit/7cf30f1f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-coho/tree/7cf30f1f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-coho/diff/7cf30f1f

Branch: refs/heads/master
Commit: 7cf30f1fc7fa3e6b0da8cd0e34804af4a7183bbf
Parents: f36d09d
Author: Andrew Grieve <ag...@chromium.org>
Authored: Thu Jun 20 00:32:00 2013 -0400
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Thu Jun 20 00:32:00 2013 -0400

----------------------------------------------------------------------
 coho | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/7cf30f1f/coho
----------------------------------------------------------------------
diff --git a/coho b/coho
index 0d6dfd2..70feed6 100755
--- a/coho
+++ b/coho
@@ -168,7 +168,7 @@ var repoGroups = {
     'active-platform': platformRepos.filter(function(r) { return !r.inactive }),
 };
 
-var performGitPush = false;
+var performGitPush = true;
 var gitPushCount = 0;
 
 function reportGitPushResult() {
@@ -715,7 +715,7 @@ function prepareReleaseBranchCommand() {
     );
     var repos = computeReposFromFlag(argv);
     var version = argv.version;
-    performGitPush = argv.push;
+    // performGitPush = argv.push;
     var branchName = version.replace(/\d+(rc\d)?$/, 'x');
 
     // First - perform precondition checks.
@@ -785,7 +785,7 @@ function tagReleaseBranchCommand(argv) {
     );
     var repos = computeReposFromFlag(argv);
     var version = argv.version;
-    performGitPush = argv.push;
+    // performGitPush = argv.push;
     var branchName = version.replace(/\d+(rc\d)?$/, 'x');
 
     // First - perform precondition checks.
@@ -809,7 +809,6 @@ function tagReleaseBranchCommand(argv) {
             // Create/update the tag.
             var tagName = retrieveCurrentTagName();
             if (tagName != version) {
-                requiresPush = true;
                 if (tagExists(version)) {
                     execHelper('git tag ' + version + ' --force');
                 } else {