You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jay Shrauner (Created) (JIRA)" <ji...@apache.org> on 2012/02/01 01:10:56 UTC
[jira] [Created] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Create update throughput quotas and add hard quota limits
---------------------------------------------------------
Key: ZOOKEEPER-1383
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
Project: ZooKeeper
Issue Type: New Feature
Components: server
Reporter: Jay Shrauner
Priority: Minor
Fix For: 3.5.0
Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197556#comment-13197556 ]
Hadoop QA commented on ZOOKEEPER-1383:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512700/ZOOKEEPER-1383.patch
against trunk revision 1238176.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/935//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/935//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/935//console
This message is automatically generated.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Camille Fournier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205964#comment-13205964 ]
Camille Fournier commented on ZOOKEEPER-1383:
---------------------------------------------
So, in short, I'm -1 on this until it stops breaking backwards compatibility. Might consider adding the update throughput quotas separately from hard quota limits.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250375#comment-13250375 ]
Jay Shrauner commented on ZOOKEEPER-1383:
-----------------------------------------
I looked at the old StatsNode deserialization code and it is possible to make this backwards compatible by exploiting some quirks in the old parsing code. The old stats nodes were serialized as
"count=5,bytes=4"
We can add new quota/stats types using the following format
"count=5,bytes=4=;bytesPerSec=100;countHardLimit=10"
The old parsing code will assert if there isn't exactly 1 ',', and it expects (but doesn't verify) that the first element is count and the second is bytes. So we put those two fields first and use semi-colons to separate all the new fields. The extra '=' after the bytes field is what tricks the old parsing into ignoring all the new fields.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Shrauner updated ZOOKEEPER-1383:
------------------------------------
Attachment: ZOOKEEPER-1383.patch
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1383:
-------------------------------------
Priority: Major (was: Minor)
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250420#comment-13250420 ]
Hadoop QA commented on ZOOKEEPER-1383:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522060/ZOOKEEPER-1383.patch
against trunk revision 1307644.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1029//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1029//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1029//console
This message is automatically generated.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Shrauner reassigned ZOOKEEPER-1383:
---------------------------------------
Assignee: Jay Shrauner
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197424#comment-13197424 ]
Jay Shrauner commented on ZOOKEEPER-1383:
-----------------------------------------
Provided the idea sounds good, please review the attached change.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202967#comment-13202967 ]
Hadoop QA commented on ZOOKEEPER-1383:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513711/ZOOKEEPER-1383.patch
against trunk revision 1240959.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/952//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/952//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/952//console
This message is automatically generated.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Camille Fournier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202969#comment-13202969 ]
Camille Fournier commented on ZOOKEEPER-1383:
---------------------------------------------
This change is definitely going to break backwards compatibility of clients in a major way. I'm not sure that it can go into a 3.X release unless we can make it not break backwards compatibility.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Shrauner updated ZOOKEEPER-1383:
------------------------------------
Attachment: ZOOKEEPER-1383.patch
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250882#comment-13250882 ]
Hadoop QA commented on ZOOKEEPER-1383:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522133/ZOOKEEPER-1383.patch
against trunk revision 1307644.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1030//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1030//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1030//console
This message is automatically generated.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250850#comment-13250850 ]
Jay Shrauner commented on ZOOKEEPER-1383:
-----------------------------------------
Updated patch to remove extra copies of createQuota and delQuota that were left behind in ZooKeeperMain when it was refactored into separate classes in cli/*
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Shrauner updated ZOOKEEPER-1383:
------------------------------------
Attachment: (was: ZOOKEEPER-1383.patch)
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Shrauner updated ZOOKEEPER-1383:
------------------------------------
Release Note: Adds support for throughput quotas (soft and hard) and hard node count and hard size quotas. Parses quota nodes from older versions of the server and preserves behavior of existing quotas (soft node count and soft size). (was: Adds support for throughput quotas (soft and hard) and hard node count and hard size quotas. Parses quota nodes from older versions of the server and preserves behavior of existing quotas (soft node count and soft size). Stat and quota nodes created with this version of the server are not parseable by older versions and thus downgrading is not supported.)
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250838#comment-13250838 ]
Jay Shrauner commented on ZOOKEEPER-1383:
-----------------------------------------
To clarify a bit: stats and quota nodes are serialized as strings, and the current code in StatsTrack expects them to serialize and parse identically with only 2 fields. This makes adding new fields problematic, and we need to add new fields to both stats and quota nodes for throughput quotas and we need to add new fields to quota nodes for hard limit quotas.
Fortunately, the parsing code in the StatsTrack constructor leaves an opening to add new fields if we don't use commas and string them after an extra = sign after the 'bytes=4' portion of the string. It's definitely a bit hacky, but it works, and it seems the easiest way to allow us to add new fields. I've added new checks in the unit tests to verify that the current StatsTrack parser continues to parse correctly the new stats/quota nodes.
I've also changed the parser so it can handle parsing unrecognized fields, which should make it easier to add new quota type in the future without having these backwards compatibility issues.
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Shrauner updated ZOOKEEPER-1383:
------------------------------------
Attachment: ZOOKEEPER-1383.patch
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Shrauner updated ZOOKEEPER-1383:
------------------------------------
Attachment: ZOOKEEPER-1383.patch
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1383) Create update throughput quotas
and add hard quota limits
Posted by "Jay Shrauner (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Shrauner updated ZOOKEEPER-1383:
------------------------------------
Attachment: ZOOKEEPER-1383.patch
> Create update throughput quotas and add hard quota limits
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1383
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Reporter: Jay Shrauner
> Assignee: Jay Shrauner
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch, ZOOKEEPER-1383.patch
>
>
> Quotas exist for size (node count and size in bytes); it would be useful to track and support quotas on update throughput (bytes per second) as well. This can be tracked on both a node/subtree level for quota support as well as on the server level for monitoring.
> In addition, the existing quotas log a warning when they are exceeded but allow the transaction to proceed (soft quotas). It would also be useful to support a corresponding set of hard quota limits that fail the transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira