[GitHub] [ozone] avijayanhwx commented on a change in pull request #2056: HDDS-4181. Add acceptance tests for upgrade, finalization and downgrade.

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #2056:
URL: https://github.com/apache/ozone/pull/2056#discussion_r603637198



##########
File path: hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/test.sh
##########
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This script tests upgrade from a previous release to the current
+# binaries.  Docker image with Ozone binaries is required for the
+# initial version, while the snapshot version uses Ozone runner image.
+
+set -e -o pipefail
+
+# Fail if required vars are not set.
+set -u
+: "${OZONE_UPGRADE_FROM}"
+: "${OZONE_UPGRADE_TO}"
+: "${TEST_DIR}"
+: "${OZONE_UPGRADE_CALLBACK}"
+set +u
+
+echo "--- RUNNING NON-ROLLING UPGRADE TEST FROM $OZONE_UPGRADE_FROM TO $OZONE_UPGRADE_TO ---"
+
+# Prepare OMs before upgrade unless this variable is not 'true'.
+: "${OZONE_PREPARE_OMS:='true'}"
+
+# Default compose cluster to use. May be overridden by callback.sh.
+source "$TEST_DIR"/compose/ha/load.sh
+source "$TEST_DIR"/testlib.sh
+source "$OZONE_UPGRADE_CALLBACK"
+
+prepare_oms() {
+  if [[ "$OZONE_PREPARE_OMS" = 'true' ]]; then
+    execute_robot_test scm upgrade/prepare.robot
+  fi
+}
+
+set_downgrade_om_args() {
+  if [[ "$OZONE_PREPARE_OMS" = 'true' ]]; then
+    export OM_HA_ARGS='--downgrade'
+  else
+    export OM_HA_ARGS='--'
+  fi
+}
+
+echo "--- SETTING UP OLD VERSION $OZONE_UPGRADE_FROM ---"
+OUTPUT_NAME="$OZONE_UPGRADE_FROM"
+callback setup
+export OM_HA_ARGS='--'
+prepare_for_image "$OZONE_UPGRADE_FROM"
+
+echo "--- RUNNING WITH OLD VERSION $OZONE_UPGRADE_FROM ---"
+start_docker_env
+callback with_old_version
+
+prepare_oms
+stop_docker_env
+prepare_for_image "$OZONE_UPGRADE_TO"
+export OM_HA_ARGS='--upgrade'
+
+echo "--- RUNNING WITH NEW VERSION $OZONE_UPGRADE_TO PRE-FINALIZED ---"
+OUTPUT_NAME="$OZONE_UPGRADE_TO"
+OZONE_KEEP_RESULTS=true start_docker_env
+callback with_new_version_pre_finalized
+
+# TODO: Start testing downgrades when 1.1.0 is released.
+# prepare_oms
+# stop_docker_env
+# prepare_for_image "$OZONE_UPGRADE_FROM"
+# set_downgrade_om_args
+
+# echo "--- RUNNING WITH OLD VERSION $OZONE_UPGRADE_FROM AFTER DOWNGRADE ---"
+# OUTPUT_NAME="$OZONE_UPGRADE_FROM"-downgraded
+# OZONE_KEEP_RESULTS=true start_docker_env
+# callback with_old_version_downgraded
+
+# prepare_oms
+# stop_docker_env
+# prepare_for_image "$OZONE_UPGRADE_TO"
+# export OM_HA_ARGS='--upgrade'
+
+echo "--- RUNNING WITH NEW VERSION $OZONE_UPGRADE_TO FINALIZED ---"

Review comment:
       Can either this 'finalize' step or the 'pre-finalize' step be skipped if there is no layout change across the upgade?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org