[GitHub] [ozone] xichen01 commented on a diff in pull request #4251: HDDS-7908. Support OM Metadata operation Generator in `Ozone freon`

["xichen01 (via GitHub)" <gi...@apache.org>]

xichen01 commented on code in PR #4251:
URL: https://github.com/apache/ozone/pull/4251#discussion_r1098635975


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java:
##########
@@ -92,6 +98,18 @@ public class BaseFreonGenerator {
       defaultValue = "10")
   private int threadNo;
 
+  @Option(names = {"--timebase"},
+      description = "If set, freon will run for the duration of the --runtime"
+          + " specified even if the --number-of-tests operation"
+          + " has been completed.",
+      defaultValue = "false")
+  private boolean timebase;
+
+  @Option(names = {"--runtime"},
+      description = "Tell freon to terminate processing after"
+          + "the specified period of time in seconds.")
+  private long runtime;

Review Comment:
   I'm not sure how --min-duration and --max-duration relate to -n.
   such as the command `freon xxx --min-duration 100  --max-duration 1000 -n 1` how long the test will be running?
   Can you give me some examples or references?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org