[jira] [Commented] (OOZIE-1761) Improve sharelib purging logic

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959488#comment-13959488 ] 

Hadoop QA commented on OOZIE-1761:
----------------------------------

Testing JIRA OOZIE-1761

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1409
.    Tests failed: 0
.    Tests errors: 1

.    The patch failed the following testcases:

.      

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1150/

> Improve sharelib purging logic
> ------------------------------
>
>                 Key: OOZIE-1761
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1761
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Purshotam Shah
>            Assignee: Purshotam Shah
>         Attachments: OOZIE-1761-V1.patch
>
>
> Currently oozie server purges anything older then 7 (oozie.ShareLibService.temp.sharelib.retention.days) days, keeping 2 latest dir.
> Which might be faulty.
> Take an example.
> Currently used sharelib is sharelib-1, which is created a month before.
> If I restart Oozie server 2 times, it will create directory sharelib-2 and sharelib-3 and delete anything older than 7 days( keeping two latest).
> In this case oozie server will delete sharelib-1, which is wrong and all running jobs will start failing.
> Better logic is to keep all share-lib between current timestamp and  7days old  + 1 latest sharelib older than 7 days.



--
This message was sent by Atlassian JIRA
(v6.2#6252)