[GitHub] [kafka] ableegoldman commented on a change in pull request #10615: KAFKA-12648: basic skeleton API for NamedTopology

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #10615:
URL: https://github.com/apache/kafka/pull/10615#discussion_r623529336



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -64,50 +97,98 @@ public static TaskId parse(final String taskIdStr) {
     /**
      * @throws IOException if cannot write to output stream
      */
-    public void writeTo(final DataOutputStream out) throws IOException {
+    public void writeTo(final DataOutputStream out, final int version) throws IOException {
         out.writeInt(topicGroupId);
         out.writeInt(partition);
+        if (version >= MIN_NAMED_TOPOLOGY_VERSION) {

Review comment:
       Although I did strip out the protocol change, I left this in since it doesn't affect anything until we actually bump the protocol version (which I did take out of this PR)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org