You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by ge...@apache.org on 2005/04/04 21:05:36 UTC

svn commit: r160089 - perl/modperl/trunk/lib/ModPerl/BuildMM.pm

Author: geoff
Date: Mon Apr  4 12:05:35 2005
New Revision: 160089

URL: http://svn.apache.org/viewcvs?view=rev&rev=160089
Log:
add manpages for stuff so that both perldoc and man work
properly

Modified:
    perl/modperl/trunk/lib/ModPerl/BuildMM.pm

Modified: perl/modperl/trunk/lib/ModPerl/BuildMM.pm
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/lib/ModPerl/BuildMM.pm?view=diff&r1=160088&r2=160089
==============================================================================
--- perl/modperl/trunk/lib/ModPerl/BuildMM.pm (original)
+++ perl/modperl/trunk/lib/ModPerl/BuildMM.pm Mon Apr  4 12:05:35 2005
@@ -245,6 +245,14 @@
                     '$(FULLPERL) -I$(INST_LIB) ' .
                     "-I$apache_test_dir -MModPerl::BuildMM " .
                     "-e ModPerl::BuildMM::glue_pod $pm $podpath $blib";
+
+                # manify while we're at it
+                my (undef, $man, undef) = $blib =~ m!(blib/lib/)(.*)(\.pm)!;
+                $man =~ s!/!::!g;
+
+                push @target,
+                    '$(NOECHO) $(POD2MAN) --section=3 ' .
+                    "$podpath \$(INST_MAN3DIR)/$man.\$(MAN3EXT)"
             }
         }
 



Re: svn commit: r160089 - perl/modperl/trunk/lib/ModPerl/BuildMM.pm

Posted by Geoffrey Young <ge...@modperlcookbook.org>.

geoff@apache.org wrote:
> Author: geoff
> Date: Mon Apr  4 12:05:35 2005
> New Revision: 160089
> 
> URL: http://svn.apache.org/viewcvs?view=rev&rev=160089
> Log:
> add manpages for stuff so that both perldoc and man work
> properly

I was essentially trying to make sure that both

  $ perldoc Apache2::RequestRec

and

  $ man Apache2::RequestRec

worked before we release the next RC.  can a few other sets of eyes look
this over and make sure things are working properly?  I _think_ it looks ok,
but that's just for me on my little system :)

oh, and if there are any other suggestions as to a better way, feel free to
reimplement it - I spent the better part of a day trying to figure this out
and finally just settled on this.

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: svn commit: r160089 - perl/modperl/trunk/lib/ModPerl/BuildMM.pm

Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> I dont' think it matters much, but why not
> 
> +                my ($man) = $blib =~ m!(?:blib/lib/)(.*)(?:\.pm)!;

because I just can't parse lookaheads (or whatever that is :)

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: svn commit: r160089 - perl/modperl/trunk/lib/ModPerl/BuildMM.pm

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
geoff@apache.org wrote:

>Author: geoff
>Date: Mon Apr  4 12:05:35 2005
>New Revision: 160089
>
>URL: http://svn.apache.org/viewcvs?view=rev&rev=160089
>Log:
>add manpages for stuff so that both perldoc and man work
>properly
>
>Modified:
>    perl/modperl/trunk/lib/ModPerl/BuildMM.pm
>
>Modified: perl/modperl/trunk/lib/ModPerl/BuildMM.pm
>URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/lib/ModPerl/BuildMM.pm?view=diff&r1=160088&r2=160089
>==============================================================================
>--- perl/modperl/trunk/lib/ModPerl/BuildMM.pm (original)
>+++ perl/modperl/trunk/lib/ModPerl/BuildMM.pm Mon Apr  4 12:05:35 2005
>@@ -245,6 +245,14 @@
>                     '$(FULLPERL) -I$(INST_LIB) ' .
>                     "-I$apache_test_dir -MModPerl::BuildMM " .
>                     "-e ModPerl::BuildMM::glue_pod $pm $podpath $blib";
>+
>+                # manify while we're at it
>+                my (undef, $man, undef) = $blib =~ m!(blib/lib/)(.*)(\.pm)!;
>+                $man =~ s!/!::!g;
>+
>+                push @target,
>+                    '$(NOECHO) $(POD2MAN) --section=3 ' .
>+                    "$podpath \$(INST_MAN3DIR)/$man.\$(MAN3EXT)"
>             }
>         }
> 
>
>
>  
>
I dont' think it matters much, but why not

+                my ($man) = $blib =~ m!(?:blib/lib/)(.*)(?:\.pm)!;



-- 
END
-----------------------------------------------------------------------------
Philip M. Gollucci
Senior Developer - Liquidity Services Inc.
Phone:  202.568.6268 (Direct)
E-Mail: pgollucci@liquidation.com
Web:    http://www.liquidation.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org