You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2010/05/13 06:18:45 UTC

[jira] Created: (HAMA-257) Design BSP program code interface

Design BSP program code interface
---------------------------------

                 Key: HAMA-257
                 URL: https://issues.apache.org/jira/browse/HAMA-257
             Project: Hama
          Issue Type: Sub-task
          Components: bsp
    Affects Versions: 0.2.0
            Reporter: Edward J. Yoon
            Assignee: Edward J. Yoon
             Fix For: 0.2.0


Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-257) Design BSP program code interface

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-257:
--------------------------------

    Attachment: HAMA-257_v02.patch

attach my patch.

> Design BSP program code interface
> ---------------------------------
>
>                 Key: HAMA-257
>                 URL: https://issues.apache.org/jira/browse/HAMA-257
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-257_v01.patch, HAMA-257_v02.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-257) Design BSP program code interface

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-257:
--------------------------------

    Attachment: HAMA-257_v03.patch

trivial changes.
----
Currently, designed as below.


  class MyBSP extends BSP {

    public MyBSP(Configuration conf) throws IOException {
      super(conf);
      // TODO Auto-generated constructor stub
    }

    @Override
    public void bsp() {
      // TODO Auto-generated method stub
      
    }
    
  }

> Design BSP program code interface
> ---------------------------------
>
>                 Key: HAMA-257
>                 URL: https://issues.apache.org/jira/browse/HAMA-257
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-257_v01.patch, HAMA-257_v02.patch, HAMA-257_v03.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-257) Design BSP program code interface

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-257:
--------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

I've just committed this.

> Design BSP program code interface
> ---------------------------------
>
>                 Key: HAMA-257
>                 URL: https://issues.apache.org/jira/browse/HAMA-257
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-257_v01.patch, HAMA-257_v02.patch, HAMA-257_v03.patch, HAMA-257_v04.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-257) Design BSP program code interface

Posted by "Hyunsik Choi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873984#action_12873984 ] 

Hyunsik Choi commented on HAMA-257:
-----------------------------------

The patch looks good! Some parts seems low level implementation, but I believe that the parts would be more neat and abstracted while the BSP package is being mature.

> Design BSP program code interface
> ---------------------------------
>
>                 Key: HAMA-257
>                 URL: https://issues.apache.org/jira/browse/HAMA-257
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-257_v01.patch, HAMA-257_v02.patch, HAMA-257_v03.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-257) Design BSP program code interface

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-257:
--------------------------------

    Attachment: HAMA-257_v01.patch

Since "Work.class" is a BSP algorithm class for a BSP job task, I changed from "setWorkClass" to "setBspClass" as below:

/** Set the BSP algorithm class for the job. */
public void setBspClass(MyBSPAlgorithm.class);

The setBspClass method sets the class which inherits abstract class BSP and implements interfaces BSPInterface. Hence, I replaced Work.class to BSP.class. BSP 

> Design BSP program code interface
> ---------------------------------
>
>                 Key: HAMA-257
>                 URL: https://issues.apache.org/jira/browse/HAMA-257
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-257_v01.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-257) Design BSP program code interface

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-257:
--------------------------------

    Status: Patch Available  (was: Open)

submitting patch.

> Design BSP program code interface
> ---------------------------------
>
>                 Key: HAMA-257
>                 URL: https://issues.apache.org/jira/browse/HAMA-257
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-257_v01.patch, HAMA-257_v02.patch, HAMA-257_v03.patch, HAMA-257_v04.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-257) Design BSP program code interface

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868146#action_12868146 ] 

Edward J. Yoon commented on HAMA-257:
-------------------------------------

As simply mentioned before, some kind of parser will be needed to provide intuitive programming API. for example, below psuedo code is BSPLib style and it looks like a perfect serial code, by wapping the parallel part with bsp_begin() and bsp_end() methods with bsp_sync() method.

    // Loop over all vertices
    for (i = 0; i < vertices.length; i++) {
      bsp_begin();
      double total = 0.0;
      int begin = index[ind];
      int end = index[ind + 1];
      //System.out.println("incoming edges: " + begin +" ~ "+ end);
    
      // Loop over edges pointing to vertex i.
      for (int j = begin; j < end; j++) {
        int src = j;
        double r = rank[src];
        double incr = r / (double) degree[src];
        total += incr;
      }
      accumulate_rank[ind] = total;
      bsp_sync();
      bsp_end();
    }

We need to figure out whether it is possible in our case. otherwise, we should support two methods such as, map and reduce.

> Design BSP program code interface
> ---------------------------------
>
>                 Key: HAMA-257
>                 URL: https://issues.apache.org/jira/browse/HAMA-257
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-257) Design BSP program code interface

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-257:
--------------------------------

    Attachment: HAMA-257_v04.patch

thank for review.

I added comments and changed bsp() to bsp(BSPPeer peer)

> Design BSP program code interface
> ---------------------------------
>
>                 Key: HAMA-257
>                 URL: https://issues.apache.org/jira/browse/HAMA-257
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-257_v01.patch, HAMA-257_v02.patch, HAMA-257_v03.patch, HAMA-257_v04.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Designing BSP program code interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.