[GitHub] [airflow] eladkal commented on issue #14392: Refer Best Practices of using Variables in the Concepts/Variables section

[GitBox <gi...@apache.org>]

eladkal commented on issue #14392:
URL: https://github.com/apache/airflow/issues/14392#issuecomment-1027291977


   > I can take a shot at improving this. I agree with @ldealmei that if you follow the example on the [Variables page](https://airflow.apache.org/docs/apache-airflow/stable/concepts/variables.html), it walks you straight into an antipattern that will slow the dag parsing down significantly.
   
   The variable doc does mention:
   
   "We also recommend that you try to keep most of your settings and configuration in your DAG files, so it can be versioned using source control; Variables are really only for values that are truly runtime-dependent."
   
   
   Also we explain in:
   https://airflow.apache.org/docs/apache-airflow/stable/best-practices.html#top-level-python-code
   
   "Specifically you should not run any database access, heavy computations and networking operations."
   
   
   I think the current doc is good enough. if someone think otherwise please explain (or better yet open a PR with your suggestion)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org