You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by khawkins <gi...@git.apache.org> on 2012/08/07 20:47:10 UTC

incubator-cordova-ios pull request: Setting the view controller's view size...

GitHub user khawkins opened a pull request:

    https://github.com/apache/incubator-cordova-ios/pull/40

    Setting the view controller's view size in viewWillAppear.

    Starting in iOS 4, the recommended way for managing views and view controllers with respect to a `UIWindow` instance is through UIWindow's `rootViewController` property, as opposed to the previous method of adding the view via `addSubview`.  Updated the inheriting view controllers and app delegates to follow the recommended pattern.
    
    **Note:** This also requires moving the code that sets the default view's frame size to the view controller's `viewWillAppear` method.  This code is managed in the consuming app's view controller (as opposed to `CDVViewController`), in the interests of Cordova modularity in developers' apps.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khawkins/incubator-cordova-ios CB-1204

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-cordova-ios/pull/40.patch

----
commit fc70ab134052a1242bd0f2b60062c12881ef14c0
Author: Kevin Hawkins <kh...@salesforce.com>
Date:   2012-08-07T11:31:30-07:00

    Setting the view controller's view size in viewWillAppear.
    
    Starting in iOS 4, the recommended way for managing views and view controllers with respect to a `UIWindow` instance is through UIWindow's `rootViewController` property, as opposed to the previous method of adding the view via `addSubview`.  Updated the inheriting view controllers and app delegates to follow the recommended pattern.
    
    **Note:** This also requires moving the code that sets the default view's frame size to the view controller's `viewWillAppear` method.  This code is managed in the consuming app's view controller (as opposed to `CDVViewController`), in the interests of Cordova modularity in developers' apps.

----