You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/08 18:03:01 UTC

[GitHub] [tvm] gromero opened a new pull request #9683: [TVM] Fix AttributeError when action is not specified

gromero opened a new pull request #9683:
URL: https://github.com/apache/tvm/pull/9683


   Although an action (build, test, or release) is always required by
   base-tool-box.py currently actions are not set as "required" in the
   parser, hence it doesn't complain when an action is missing and later
   when 'args.platform' attribute (present in all actions) is referenced
   the tool exits abruptly due to an AttributeError (because 'platform' is
   not set), without giving any clue on what went wrong. For instance:
   
   $ python3 ./base-box-tool.py --provider virtualbox # no action is given
   
   This commit fixes it by setting action subparsers as required so the
   parser complains when no action is specified.
   
   Signed-off-by: Gustavo Romero <gu...@linaro.org>
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] gromero commented on pull request #9683: [RVM] Fix AttributeError when action is not specified

Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9683:
URL: https://github.com/apache/tvm/pull/9683#issuecomment-989047474


   cc @areusch @mehrdadh @leandron for reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron merged pull request #9683: [RVM] Fix AttributeError when action is not specified

Posted by GitBox <gi...@apache.org>.
leandron merged pull request #9683:
URL: https://github.com/apache/tvm/pull/9683


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org