You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "da-woods (via GitHub)" <gi...@apache.org> on 2023/03/24 17:48:04 UTC

[GitHub] [arrow] da-woods commented on pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3

da-woods commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1483189110

   A couple of quick comments:
   
   > * `&&` is no longer supported
   > * nogil must appear at the end of the line
   
   I think these are both warnings (so don't *have* to be breaking changes).
   
   `&&` was never really supported. It just got interpreted as "reference to reference". Now we understand it in a few limited contexts, so issue a warning for the other contexts.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org