You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/18 17:16:19 UTC

[GitHub] [activemq-artemis] gaohoward edited a comment on issue #2432: [ARTEMIS-2176] RA connection properties are not propagated to XARecov…

gaohoward edited a comment on issue #2432: [ARTEMIS-2176] RA connection properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#issuecomment-587572338
 
 
   > There is outstanding comments on this, are these being addressed?
   
   Hi Guys,
   I've tried some refactoring based on @spyrkob's work. Basically I extracted the relevant properties from ServicerLocator into a ServerLocatorConfig class so that it can be reused for creating new locators in XARecoveryConfig. Please take a look at my branch and tell me what you think:
   
   https://github.com/gaohoward/activemq-artemis/blob/spyrkob-ARTEMIS-2176/artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java#L48
   
   https://github.com/apache/activemq-artemis/compare/master...gaohoward:spyrkob-ARTEMIS-2176?expand=1
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services