[GitHub] [incubator-hudi] n3nash commented on a change in pull request #1075: [HUDI-114]: added option to overwrite payload implementation in hoodie.properties file

[GitBox <gi...@apache.org>]

n3nash commented on a change in pull request #1075: [HUDI-114]: added option to overwrite payload implementation in hoodie.properties file
URL: https://github.com/apache/incubator-hudi/pull/1075#discussion_r354503414
 
 

 ##########
 File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
 ##########
 @@ -228,6 +228,10 @@ public Operation convert(String value) throws ParameterException {
         + " source-fetch -> Transform -> Hudi Write in loop")
     public Boolean continuousMode = false;
 
+    @Parameter(names = {"--update-payload-class"}, description = "Update payload class in hoodie.properties file if needed, "
 
 Review comment:
   @pratyakshsharma I actually agree with @vinothchandar, we should just check `hoodie.properties` and overwrite if it's different. We don't necessarily want to create guards if someone does actually provide a different class by mistake

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services