[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14065: [Test] Remove junit

[GitBox <gi...@apache.org>]

nicoloboschi commented on a change in pull request #14065:
URL: https://github.com/apache/pulsar/pull/14065#discussion_r797007144



##########
File path: pulsar-io/flume/src/test/java/org/apache/pulsar/io/flume/node/TestEnvVarResolverProperties.java
##########
@@ -18,32 +18,32 @@
  */
 package org.apache.pulsar.io.flume.node;
 
+import static org.testng.Assert.assertEquals;
 import java.io.File;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
 import org.junit.contrib.java.lang.system.EnvironmentVariables;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
 
 public final class TestEnvVarResolverProperties {
     private static final File TESTFILE = new File(
             TestEnvVarResolverProperties.class.getClassLoader()
                     .getResource("flume-conf-with-envvars.properties").getFile());
 
-    @Rule
-    public final EnvironmentVariables environmentVariables = new EnvironmentVariables();
+    public EnvironmentVariables environmentVariables;
     private PropertiesFileConfigurationProvider provider;
 
-    @Before
+    @BeforeMethod
     public void setUp() {
         provider = new PropertiesFileConfigurationProvider("a1", TESTFILE);
+        environmentVariables = new EnvironmentVariables();
+        System.out.println(environmentVariables);

Review comment:
       is it intentional ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org