You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2024/09/23 17:49:18 UTC
[PR] JCRVLT-784: BinaryPropertiesIT.exportBinary: improve diagnostics when entry is missing [jackrabbit-filevault]
reschke opened a new pull request, #354:
URL: https://github.com/apache/jackrabbit-filevault/pull/354
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-784: BinaryPropertiesIT.exportBinary: improve diagnostics when entry is missing [jackrabbit-filevault]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke merged PR #354:
URL: https://github.com/apache/jackrabbit-filevault/pull/354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JCRVLT-784: BinaryPropertiesIT.exportBinary: improve diagnostics when entry is missing [jackrabbit-filevault]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #354:
URL: https://github.com/apache/jackrabbit-filevault/pull/354#discussion_r1772024443
##########
vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/BinaryPropertiesIT.java:
##########
@@ -228,25 +228,41 @@ private VaultPackage assemblePackage(String rootNodePath) throws IOException, Re
return packMgr.assemble(admin, opts, tmpFile);
}
+ private void getArchiveContents(List<String> list, String path, Archive.Entry entry) {
+ String fullname = path + entry.getName();
+ list.add(fullname);
+ for (Archive.Entry en : entry.getChildren()) {
+ getArchiveContents(list, fullname + "/", en);
+ }
+ }
+
+ private void checkExistingMember(Archive archive, String member, List<String> existing) throws IOException {
Review Comment:
maybe implementing with Hamcrest as https://hamcrest.org/JavaHamcrest/javadoc/2.2/org/hamcrest/BaseMatcher.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org