You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Arpit Gupta (Created) (JIRA)" <ji...@apache.org> on 2011/12/20 22:57:30 UTC
[jira] [Created] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Add support for --config to zkEnv.sh to specify a config directory different than what is expected
--------------------------------------------------------------------------------------------------
Key: ZOOKEEPER-1335
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
Project: ZooKeeper
Issue Type: Improvement
Reporter: Arpit Gupta
zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Arpit Gupta (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252044#comment-13252044 ]
Arpit Gupta commented on ZOOKEEPER-1335:
----------------------------------------
@Patrik wondering if you could take look at the patch and see if its good to go.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch, ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Arpit Gupta (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173725#comment-13173725 ]
Arpit Gupta commented on ZOOKEEPER-1335:
----------------------------------------
no tests added as changes are to shell scripts.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Arpit Gupta (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated ZOOKEEPER-1335:
-----------------------------------
Attachment: ZOOKEEPER-1335.patch
Still calling the option '--config' as i prefer usage is similar to other projects.
Updated the usage information in the zkServer.sh.
I briefly looked at the existing forrest docs and could not find a place where we talk about where we expect the config directories to be. So dont have any forrest doc updates in this patch.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch, ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173699#comment-13173699 ]
Hadoop QA commented on ZOOKEEPER-1335:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508135/ZOOKEEPER-1335.patch
against trunk revision 1214571.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/843//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/843//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/843//console
This message is automatically generated.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Arpit Gupta (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated ZOOKEEPER-1335:
-----------------------------------
Attachment: ZOOKEEPER-1335.patch
attached a patch for trunk.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Attachments: ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176469#comment-13176469 ]
Patrick Hunt commented on ZOOKEEPER-1335:
-----------------------------------------
@arpit I'd rather use configdir but if you want to use config I'm fine with it. re docs the main issue is the usage information for the scripts themselves, not sure about the forrest docs but yes, it would be good to update those as well if possible/necessary.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Arpit Gupta (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176403#comment-13176403 ]
Arpit Gupta commented on ZOOKEEPER-1335:
----------------------------------------
@Patric I will take a look at the docs and update the the patch with the doc updates. Regarding the '--config' the reason i choose that is because other projects like hadoop , hbase etc use the same name and it also points to a dir containing the configs. Figured keeping them the same would be better.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Mahadev konar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1335:
-------------------------------------
Fix Version/s: 3.5.0
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262271#comment-13262271 ]
Hadoop QA commented on ZOOKEEPER-1335:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508785/ZOOKEEPER-1335.patch
against trunk revision 1330043.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1052//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1052//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1052//console
This message is automatically generated.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch, ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Arpit Gupta (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated ZOOKEEPER-1335:
-----------------------------------
Description:
zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
With this you should be able to do
/usr/sbin/zkServer.sh --config /some/conf/dir start|stop
was:zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1335) Add support for --config to
zkEnv.sh to specify a config directory different than what is expected
Posted by "Mahadev konar (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-1335:
----------------------------------------
Assignee: Arpit Gupta
> Add support for --config to zkEnv.sh to specify a config directory different than what is expected
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1335
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1335
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Arpit Gupta
> Assignee: Arpit Gupta
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1335.patch
>
>
> zkEnv.sh expects ZOOCFGDIR env variable set. If not it looks for the conf dir in the ZOOKEEPER_PREFIX dir or in /etc/zookeeper. It would be great if we can support --config option where at run time you could specify a different config directory. We do the same thing in hadoop.
> With this you should be able to do
> /usr/sbin/zkServer.sh --config /some/conf/dir start|stop
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira