You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/01 13:23:00 UTC
[jira] [Work logged] (SSHD-1273) Send environment variable and open subsystem at the same time for SSH session
[ https://issues.apache.org/jira/browse/SSHD-1273?focusedWorklogId=787099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-787099 ]
ASF GitHub Bot logged work on SSHD-1273:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/22 13:22
Start Date: 01/Jul/22 13:22
Worklog Time Spent: 10m
Work Description: tomaswolf commented on code in PR #230:
URL: https://github.com/apache/mina-sshd/pull/230#discussion_r911959262
##########
sshd-core/src/main/java/org/apache/sshd/client/channel/PtyCapableChannelSession.java:
##########
@@ -200,21 +200,6 @@ public void setPtyModes(Map<PtyMode, Integer> ptyModes) {
config.setPtyModes((ptyModes == null) ? Collections.emptyMap() : ptyModes);
}
- /**
- * @param key The (never {@code null}) key (Note: may be empty...)
- * @param value The value to set - if {@code null} then the pre-existing value for the key (if any) is
- * <U>removed</U>.
- * @return The replaced/removed previous value - {@code null} if no previous value set for the key.
- */
- public Object setEnv(String key, Object value) {
- ValidateUtils.checkNotNull(key, "No key provided");
- if (value == null) {
- return env.remove(key);
- } else {
- return env.put(key, value);
- }
- }
-
Review Comment:
Also remove the map in line 88.
Issue Time Tracking
-------------------
Worklog Id: (was: 787099)
Remaining Estimate: 0h
Time Spent: 10m
> Send environment variable and open subsystem at the same time for SSH session
> -----------------------------------------------------------------------------
>
> Key: SSHD-1273
> URL: https://issues.apache.org/jira/browse/SSHD-1273
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Andrei Danilenka
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I use Apache Mina SSH client. The request that I want to send looks like:
> {code:java}
> user@host -w my_password -o SendEnv=SOME_VAR -s subsystem_name{code}
> But for now it is impossible to use env vars and subsystem together.
> What I have tried so far
> 1. ChannelShell class has setEnv(key, value) method but I can't go in
> subsystem
> 2. ChannelSubsystem class allows to go to subsystem but it has no
> setEnv(key, value) method
> 3. Also I have tried to open ChannelShell, set env, then open
> ChannelSubsystem using the same session as was used for ChannelShell, but it
> seems env variable hasn't gotten to ChannelSubsystem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org