[GitHub] spark pull request #18070: [SPARK-20713][Spark Core] Convert CommitDenied to...

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18070#discussion_r117977100
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -338,6 +340,9 @@ private[spark] class Executor(
                 metricsSystem = env.metricsSystem)
               threwException = false
               res
    +        } catch {
    +          case _: CommitDeniedException =>
    +            throw new TaskKilledException("commit denied")
    --- End diff --
    
    I'm not sure we want to just convert it here. I was originally thinking we would fix it up on the driver side because it knows that it explicitly a speculative task and it killed it.  Here we don't know that for sure.
    
    for instance you might have got a commit denied because the stage was aborted due to fetch failure.  That shouldn't show up as killed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org