You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/17 21:58:12 UTC
[GitHub] [druid] sthetland opened a new pull request #10405: Document change in results of groupBy queries with subtotalsSpec
sthetland opened a new pull request #10405:
URL: https://github.com/apache/druid/pull/10405
Document the behavior change in 0.18 and later to the structure of the response generated by a subtotalsSpec, as implemented by https://github.com/apache/druid/pull/9438.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #10405: Document change in results of groupBy queries with subtotalsSpec
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #10405:
URL: https://github.com/apache/druid/pull/10405#discussion_r491099832
##########
File path: docs/querying/groupbyquery.md
##########
@@ -172,8 +175,8 @@ The subtotals feature allows computation of multiple sub-groupings in a single q
}
```
-Response returned would be equivalent to concatenating result of 3 groupBy queries with "dimensions" field being ["D1", "D2", D3"], ["D1", "D3"] and ["D3"] with appropriate `DimensionSpec` json blob as used in above query.
-Response for above query would look something like below...
+The result of the subtotalSpec would be equivalent to concatenating the result of three groupBy queries, with the "dimensions" field being `["D1", "D2", D3"]`, `["D1", "D3"]` and `["D3"]`, given the `DimensionSpec` shown above.
Review comment:
The spell bot noticed a typo: `subtotalSpec` -> `subtotalsSpec`.
##########
File path: docs/querying/groupbyquery.md
##########
@@ -172,8 +175,8 @@ The subtotals feature allows computation of multiple sub-groupings in a single q
}
```
-Response returned would be equivalent to concatenating result of 3 groupBy queries with "dimensions" field being ["D1", "D2", D3"], ["D1", "D3"] and ["D3"] with appropriate `DimensionSpec` json blob as used in above query.
-Response for above query would look something like below...
+The result of the subtotalSpec would be equivalent to concatenating the result of three groupBy queries, with the "dimensions" field being `["D1", "D2", D3"]`, `["D1", "D3"]` and `["D3"]`, given the `DimensionSpec` shown above.
+The response for the query above query would look something like:
Review comment:
The query in `the query above query` seems duplicate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #10405: Document change in results of groupBy queries with subtotalsSpec
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #10405:
URL: https://github.com/apache/druid/pull/10405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] sthetland commented on a change in pull request #10405: Document change in results of groupBy queries with subtotalsSpec
Posted by GitBox <gi...@apache.org>.
sthetland commented on a change in pull request #10405:
URL: https://github.com/apache/druid/pull/10405#discussion_r491246230
##########
File path: docs/querying/groupbyquery.md
##########
@@ -172,8 +175,8 @@ The subtotals feature allows computation of multiple sub-groupings in a single q
}
```
-Response returned would be equivalent to concatenating result of 3 groupBy queries with "dimensions" field being ["D1", "D2", D3"], ["D1", "D3"] and ["D3"] with appropriate `DimensionSpec` json blob as used in above query.
-Response for above query would look something like below...
+The result of the subtotalSpec would be equivalent to concatenating the result of three groupBy queries, with the "dimensions" field being `["D1", "D2", D3"]`, `["D1", "D3"]` and `["D3"]`, given the `DimensionSpec` shown above.
+The response for the query above query would look something like:
Review comment:
yep, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org