You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/27 03:01:04 UTC

[GitHub] [pulsar] aloyszhang opened a new pull request #9067: Peek

aloyszhang opened a new pull request #9067:
URL: https://github.com/apache/pulsar/pull/9067


   ### Motivation
   This pull requeset adds `Commands.peekBrokerEntryMetadataIfExist` method to support peek broker entry metadata.
   
   This will be used in protocol handler KOP.  
   Currently, when handles `FetchRequest`, KOP will
   1. firset read `Entry` out of ledger
   2. get `BaseOffset` from `Enty` for building `MemoryRecordsBuilder`
   3. traverse every `Entry` and add each message into `MemoryRecordsBuilder`
   we need the `Entry` twice, first for peeking the offset and second for buiding `MemoryRecordsBuilder`.
   
   So, we should support only peek the broker entry metadata without changing the original entry content.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #9067: support peek broker entry metadta

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9067:
URL: https://github.com/apache/pulsar/pull/9067#issuecomment-751428944


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] aloyszhang commented on pull request #9067: support peek broker entry metadta

Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #9067:
URL: https://github.com/apache/pulsar/pull/9067#issuecomment-751435285


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #9067: support peek broker entry metadta

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9067:
URL: https://github.com/apache/pulsar/pull/9067


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org