svn commit: r1404133 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/EffectiveNodeTypeProvider.java

[md...@apache.org]

Author: mduerig
Date: Wed Oct 31 13:27:29 2012
New Revision: 1404133

URL: http://svn.apache.org/viewvc?rev=1404133&view=rev
Log:
OAK-412: Review effective node type calculations
 TODO

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/EffectiveNodeTypeProvider.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/EffectiveNodeTypeProvider.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/EffectiveNodeTypeProvider.java?rev=1404133&r1=1404132&r2=1404133&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/EffectiveNodeTypeProvider.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/EffectiveNodeTypeProvider.java Wed Oct 31 13:27:29 2012
@@ -25,11 +25,13 @@ import org.apache.jackrabbit.oak.api.Tre
 /**
  * EffectiveNodeTypeProvider... TODO
  *
- * FIXME: see also TypeValidator which has it's own private EffectiveNodeType class.
+ * FIXME: see also TypeValidator which has it's own private EffectiveNodeType class. See OAK-412
  */
 public interface EffectiveNodeTypeProvider {
 
     /**
+     * FIXME in contrast what the method name implies this method returns the transitive closure of the super types
+     * TODO clarify contract, what is the difference between this method and NodeType.getSuperTypes()
      * Calculates and returns all effective node types of the given node.
      *
      * @param targetNode the node for which the types should be calculated.
@@ -39,6 +41,8 @@ public interface EffectiveNodeTypeProvid
     Iterable<NodeType> getEffectiveNodeTypes(Node targetNode) throws RepositoryException;
 
     /**
+     * FIXME in contrast what the method name implies this method returns the transitive closure of the super types
+     * TODO clarify contract, what is the difference between this method and NodeType.getSuperTypes()
      * Calculates and returns all effective node types of the given tree.
      *
      * @param tree