[GitHub] [arrow] cyb70289 commented on a change in pull request #9975: ARROW-12325: [C++] [CI] Nightly gandiva build failing due to failure of compiler to move return value

[GitBox <gi...@apache.org>]

cyb70289 commented on a change in pull request #9975:
URL: https://github.com/apache/arrow/pull/9975#discussion_r614550187



##########
File path: cpp/src/arrow/util/vector.h
##########
@@ -130,7 +130,7 @@ Result<std::vector<T>> UnwrapOrRaise(std::vector<Result<T>>&& results) {
     }
     out.push_back(it->MoveValueUnsafe());
   }
-  return out;
+  return std::move(out);

Review comment:
       Looks to me this `std::move` does no harm.
   Regarding RVO, as we are returning `Result` wrapped object, not the object itself, to my knowledge, there must be a temporary object to be moved or copied by `Result`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org