You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2024/09/27 09:53:00 UTC
[jira] [Commented] (CASSANDRA-19960) CommitLogArchiver in CommitLog should be final (19448 follow-up)
[ https://issues.apache.org/jira/browse/CASSANDRA-19960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885300#comment-17885300 ]
Stefan Miklosovic commented on CASSANDRA-19960:
-----------------------------------------------
[CASSANDRA-19448-followup|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19448-followup]
{noformat}
java17_pre-commit_tests
✓ j17_build 4m 32s
✓ j17_cqlsh_dtests_py311 6m 52s
✓ j17_cqlsh_dtests_py311_vnode 7m 24s
✓ j17_cqlsh_dtests_py38 6m 50s
✓ j17_cqlsh_dtests_py38_vnode 7m 40s
✓ j17_cqlshlib_cython_tests 11m 5s
✓ j17_cqlshlib_tests 6m 46s
✓ j17_dtests 32m 48s
✓ j17_dtests_latest 35m 10s
✓ j17_dtests_vnode 35m 23s
✓ j17_jvm_dtests 23m 23s
✓ j17_unit_tests_repeat 3m 30s
✓ j17_utests_latest_repeat 3m 12s
✓ j17_utests_oa_repeat 3m 15s
✕ j17_jvm_dtests_latest_vnode 22m 22s
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest testMoveToCMS
✕ j17_unit_tests 14m 32s
org.apache.cassandra.net.ConnectionTest testTimeout
✕ j17_utests_latest 15m 16s
org.apache.cassandra.db.compaction.CompactionStrategyManagerPendingRepairTest testFinalizedAndCompactionRace
✕ j17_utests_oa 15m 27s
org.apache.cassandra.db.commitlog.CommitlogShutdownTest testShutdownWithPendingTasks
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4831/workflows/0ac8bbc3-e072-4c1f-aeb7-95e863537c33]
> CommitLogArchiver in CommitLog should be final (19448 follow-up)
> ----------------------------------------------------------------
>
> Key: CASSANDRA-19960
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19960
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is follow-up for CASSANDRA-19448, we made CommitLogArchiver non-final but not volatile. This might cause issues. We just need to return it back to final and remove the setter. The fact it is non-final now is because it was more comfortable to write tests but there is not any reason to keep it like that if tests are rewritten a little bit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org