You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/07/29 01:18:16 UTC
[jira] Created: (HBASE-2887) Improvements and refactor for
HBaseFsck tool
Improvements and refactor for HBaseFsck tool
--------------------------------------------
Key: HBASE-2887
URL: https://issues.apache.org/jira/browse/HBASE-2887
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Refactored the way the HBaseFsck tool works -- it now loads all the info it can find into RAM first, and then looks over the in-memory structures for inconsistencies. It's still a work in progress, but detects more kinds of problems now (eg multiple assignment, etc) and has some very basic functional tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2887) Improvements and refactor for
HBaseFsck tool
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900114#action_12900114 ]
HBase Review Board commented on HBASE-2887:
-------------------------------------------
Message from: "Todd Lipcon" <to...@cloudera.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review956
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment3119>
good catch! Yep, I think so.
- Todd
> Improvements and refactor for HBaseFsck tool
> --------------------------------------------
>
> Key: HBASE-2887
> URL: https://issues.apache.org/jira/browse/HBASE-2887
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> Refactored the way the HBaseFsck tool works -- it now loads all the info it can find into RAM first, and then looks over the in-memory structures for inconsistencies. It's still a work in progress, but detects more kinds of problems now (eg multiple assignment, etc) and has some very basic functional tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2887) Improvements and refactor for
HBaseFsck tool
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893426#action_12893426 ]
HBase Review Board commented on HBASE-2887:
-------------------------------------------
Message from: "Todd Lipcon" <to...@cloudera.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/
-----------------------------------------------------------
Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppan.
Summary
-------
Bunch of changes to the HBaseFsck tool to detect a wider variety of issues and to make it easier to add "fix" support for these problems in the future.
This addresses bug HBASE-2887.
http://issues.apache.org/jira/browse/HBASE-2887
Diffs
-----
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1
src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909
src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREATION
Diff: http://review.cloudera.org/r/418/diff
Testing
-------
Tested an earlier variation of this patch against my cluster in various screwed up states. This patch adds a basic unit test but it could be improved to use a mock cluster and test more variations.
Thanks,
Todd
> Improvements and refactor for HBaseFsck tool
> --------------------------------------------
>
> Key: HBASE-2887
> URL: https://issues.apache.org/jira/browse/HBASE-2887
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> Refactored the way the HBaseFsck tool works -- it now loads all the info it can find into RAM first, and then looks over the in-memory structures for inconsistencies. It's still a work in progress, but detects more kinds of problems now (eg multiple assignment, etc) and has some very basic functional tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-2887) Improvements and refactor for
HBaseFsck tool
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reassigned HBASE-2887:
----------------------------------
Assignee: Jonathan Gray (was: Todd Lipcon)
Reassigning to jgray - FB team is taking this and running with it.
> Improvements and refactor for HBaseFsck tool
> --------------------------------------------
>
> Key: HBASE-2887
> URL: https://issues.apache.org/jira/browse/HBASE-2887
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Jonathan Gray
>
> Refactored the way the HBaseFsck tool works -- it now loads all the info it can find into RAM first, and then looks over the in-memory structures for inconsistencies. It's still a work in progress, but detects more kinds of problems now (eg multiple assignment, etc) and has some very basic functional tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2887) Improvements and refactor for
HBaseFsck tool
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893512#action_12893512 ]
HBase Review Board commented on HBASE-2887:
-------------------------------------------
Message from: stack@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review533
-----------------------------------------------------------
Ship it!
Looks great to me. Few comments below.
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment2127>
How do I supply different implementation of ErrorReporter?
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment2128>
What about logs dir and old logs dir -- we skipping them here?
src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java
<http://review.cloudera.org/r/418/#comment2130>
White space. Better remove it if you'd avoid wrath of Benôit.
- stack
> Improvements and refactor for HBaseFsck tool
> --------------------------------------------
>
> Key: HBASE-2887
> URL: https://issues.apache.org/jira/browse/HBASE-2887
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> Refactored the way the HBaseFsck tool works -- it now loads all the info it can find into RAM first, and then looks over the in-memory structures for inconsistencies. It's still a work in progress, but detects more kinds of problems now (eg multiple assignment, etc) and has some very basic functional tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2887) Improvements and refactor for
HBaseFsck tool
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901083#action_12901083 ]
HBase Review Board commented on HBASE-2887:
-------------------------------------------
Message from: "dhruba borthakur" <dh...@gmail.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review993
-----------------------------------------------------------
looks good to me.
- dhruba
> Improvements and refactor for HBaseFsck tool
> --------------------------------------------
>
> Key: HBASE-2887
> URL: https://issues.apache.org/jira/browse/HBASE-2887
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> Refactored the way the HBaseFsck tool works -- it now loads all the info it can find into RAM first, and then looks over the in-memory structures for inconsistencies. It's still a work in progress, but detects more kinds of problems now (eg multiple assignment, etc) and has some very basic functional tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2887) Improvements and refactor for
HBaseFsck tool
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900115#action_12900115 ]
HBase Review Board commented on HBASE-2887:
-------------------------------------------
Message from: "Alexander Georgiev" <es...@gmail.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review955
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment3116>
Shouldn't this be "greater than" instead of "less than"? Otherwise we are looking for errors only in elements changed in the last timelag milliseconds, which is exactly the opposite of what we want.
- Alexander
> Improvements and refactor for HBaseFsck tool
> --------------------------------------------
>
> Key: HBASE-2887
> URL: https://issues.apache.org/jira/browse/HBASE-2887
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> Refactored the way the HBaseFsck tool works -- it now loads all the info it can find into RAM first, and then looks over the in-memory structures for inconsistencies. It's still a work in progress, but detects more kinds of problems now (eg multiple assignment, etc) and has some very basic functional tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.