You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/18 17:10:13 UTC
[GitHub] [arrow] sweb opened a new pull request #9248: ARROW-11304: [Rust] add casts from / to DecimalArray [WIP]
sweb opened a new pull request #9248:
URL: https://github.com/apache/arrow/pull/9248
Adds casts from other arrays to `DecimalArray` and back
Still WIP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sweb closed pull request #9248: ARROW-11304: [Rust] add casts from / to DecimalArray [WIP]
Posted by GitBox <gi...@apache.org>.
sweb closed pull request #9248:
URL: https://github.com/apache/arrow/pull/9248
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9248: ARROW-11304: [Rust] add casts from / to DecimalArray [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9248:
URL: https://github.com/apache/arrow/pull/9248#issuecomment-762375351
https://issues.apache.org/jira/browse/ARROW-11304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9248: ARROW-11304: [Rust] add casts from / to DecimalArray [WIP]
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9248:
URL: https://github.com/apache/arrow/pull/9248#issuecomment-762411660
@ovr seems to be implementing decimal on #9232, may you please coordinate so that you don't end up stepping on each other's toes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9248: ARROW-11304: [Rust] add casts from / to DecimalArray [WIP]
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9248:
URL: https://github.com/apache/arrow/pull/9248#issuecomment-762417552
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9248?src=pr&el=h1) Report
> Merging [#9248](https://codecov.io/gh/apache/arrow/pull/9248?src=pr&el=desc) (dbafcb2) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.02%`.
> The diff coverage is `89.36%`.
[](https://codecov.io/gh/apache/arrow/pull/9248?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9248 +/- ##
==========================================
+ Coverage 81.61% 81.63% +0.02%
==========================================
Files 215 215
Lines 51867 51985 +118
==========================================
+ Hits 42329 42437 +108
- Misses 9538 9548 +10
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9248?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow/pull/9248/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Nhc3QucnM=) | `96.58% <88.60%> (-0.41%)` | :arrow_down: |
| [rust/arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow/pull/9248/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYnVpbGRlci5ycw==) | `86.04% <93.33%> (+0.14%)` | :arrow_up: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9248/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
| [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9248/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.66% <0.00%> (+0.16%)` | :arrow_up: |
| [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9248/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `84.21% <0.00%> (+5.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9248?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9248?src=pr&el=footer). Last update [864c2b0...dbafcb2](https://codecov.io/gh/apache/arrow/pull/9248?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sweb commented on pull request #9248: ARROW-11304: [Rust] add casts from / to DecimalArray [WIP]
Posted by GitBox <gi...@apache.org>.
sweb commented on pull request #9248:
URL: https://github.com/apache/arrow/pull/9248#issuecomment-762639772
@nevi-me thank you for letting me know! I think it makes sense to close this PR and wait until `DecimalType` is available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org