[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely

["Naganarasimha G R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312068#comment-14312068 ] 

Naganarasimha G R commented on YARN-3157:
-----------------------------------------

Hi [~bibinchundatt],
Thanks for raising this issue , its good to have a proper error message on improper input than having some stack trace, 
*  can you also add some test code for the same 
*  Need to do the same check for container id too.
*  may be modify title "Better Error message handling for invalid application id or attempt id or container Id" (in these lines)

> Wrong format for application id / attempt id not handled completely
> -------------------------------------------------------------------
>
>                 Key: YARN-3157
>                 URL: https://issues.apache.org/jira/browse/YARN-3157
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
>         at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
>         at org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
>         at org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)