You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/08/19 16:58:10 UTC
[GitHub] couchdb-fauxton pull request: enable include_docs per default
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/499
enable include_docs per default
- shows document content
- do not override the amount of displayed docs and set it to 100
when clicking back
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton include-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #499
----
commit 81f46f6662f7addc40f6976920f9007113d46fe4
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-08-19T14:55:52Z
enable include_docs per default
- shows document content
- do not override the amount of displayed docs and set it to 100
when clicking back
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: enable include_docs per default
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-132785020
:/ maybe test for how big a document is before showing it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #499: [DISCUSSION] enable include_docs per default
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/499
This will be fixed when we switch to a more default table view.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: enable include_docs per default
Posted by elistevens <gi...@git.apache.org>.
Github user elistevens commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-132796204
I would like to have it in the user's hands, off by default. Sometimes I'm going to want to see 400mb of JSON, but it will be rare.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: enable include_docs per default
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-132699298
That was so long time ago initially. The problem is that indexes pages view turns into nightmare when you deal with big documents since you cannot disable this option before actual request is made.
Imagine 4MiB documents in db. 100 per page (default) -> 400MiB of received JSON which need to parse and render. Default options shouldn't hurt users in any situations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: enable include_docs per default
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-138494375
We are planning table views, see also the data importer that is about to land
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: enable include_docs per default
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-132786545
no that wouldn't be good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: enable include_docs per default
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-132785883
@michellephung Good idea, and it's possible with additional HEAD request per document. 100 rows per page - 100 additional requests, but do we really need that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: enable include_docs per default
Posted by willholley <gi...@git.apache.org>.
Github user willholley commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-132913244
how about off by default but remembering the setting between visits to the page (could be per-database / view)? The large documents problem happens regardless of when the user uses include_docs so it sounds like a separate ticket / fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #499: [DISCUSSION] enable include_docs per defa...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---