You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Claudio Martella (Created) (JIRA)" <ji...@apache.org> on 2011/11/16 22:21:51 UTC
[jira] [Created] (GIRAPH-90) LongDoubleFloatDoubleVertex has
possibily the iterator() implementation broken
LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken
------------------------------------------------------------------------------
Key: GIRAPH-90
URL: https://issues.apache.org/jira/browse/GIRAPH-90
Project: Giraph
Issue Type: Bug
Components: graph
Affects Versions: 0.70.0
Reporter: Claudio Martella
Assignee: Claudio Martella
Fix For: 0.70.0
iterator() implementation returns LongWritable which is cached in a final variable and set() with the new value at next(). This could be misleading as the user might create a list from the iterator's data. Something similar is happening in the getMsgList() as well.
Is this really what we want?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-90) LongDoubleFloatDoubleVertex has
possibily the iterator() implementation broken
Posted by "Claudio Martella (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claudio Martella updated GIRAPH-90:
-----------------------------------
Attachment: GIRAPH-90.diff
2-liners, removes caching.
> LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken
> ------------------------------------------------------------------------------
>
> Key: GIRAPH-90
> URL: https://issues.apache.org/jira/browse/GIRAPH-90
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Fix For: 0.70.0
>
> Attachments: GIRAPH-90.diff
>
>
> iterator() implementation returns LongWritable which is cached in a final variable and set() with the new value at next(). This could be misleading as the user might create a list from the iterator's data. Something similar is happening in the getMsgList() as well.
> Is this really what we want?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-90) LongDoubleFloatDoubleVertex has
possibily the iterator() implementation broken
Posted by "Claudio Martella (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151541#comment-13151541 ]
Claudio Martella commented on GIRAPH-90:
----------------------------------------
OK, i'll fix this.
> LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken
> ------------------------------------------------------------------------------
>
> Key: GIRAPH-90
> URL: https://issues.apache.org/jira/browse/GIRAPH-90
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Fix For: 0.70.0
>
>
> iterator() implementation returns LongWritable which is cached in a final variable and set() with the new value at next(). This could be misleading as the user might create a list from the iterator's data. Something similar is happening in the getMsgList() as well.
> Is this really what we want?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-90) LongDoubleFloatDoubleVertex has
possibily the iterator() implementation broken
Posted by "Claudio Martella (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claudio Martella resolved GIRAPH-90.
------------------------------------
Resolution: Fixed
> LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken
> ------------------------------------------------------------------------------
>
> Key: GIRAPH-90
> URL: https://issues.apache.org/jira/browse/GIRAPH-90
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Fix For: 0.70.0
>
> Attachments: GIRAPH-90.diff
>
>
> iterator() implementation returns LongWritable which is cached in a final variable and set() with the new value at next(). This could be misleading as the user might create a list from the iterator's data. Something similar is happening in the getMsgList() as well.
> Is this really what we want?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-90) LongDoubleFloatDoubleVertex has
possibily the iterator() implementation broken
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156994#comment-13156994 ]
Avery Ching commented on GIRAPH-90:
-----------------------------------
+1, feel free to commit Claudio.
> LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken
> ------------------------------------------------------------------------------
>
> Key: GIRAPH-90
> URL: https://issues.apache.org/jira/browse/GIRAPH-90
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Fix For: 0.70.0
>
> Attachments: GIRAPH-90.diff
>
>
> iterator() implementation returns LongWritable which is cached in a final variable and set() with the new value at next(). This could be misleading as the user might create a list from the iterator's data. Something similar is happening in the getMsgList() as well.
> Is this really what we want?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-90) LongDoubleFloatDoubleVertex has
possibily the iterator() implementation broken
Posted by "Claudio Martella (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157130#comment-13157130 ]
Claudio Martella commented on GIRAPH-90:
----------------------------------------
Done. Committed with wrong reference in commit log (GIRAPH-98). Here's hudson's feedback:
https://issues.apache.org/jira/browse/GIRAPH-98?focusedCommentId=13157127&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13157127
> LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken
> ------------------------------------------------------------------------------
>
> Key: GIRAPH-90
> URL: https://issues.apache.org/jira/browse/GIRAPH-90
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Fix For: 0.70.0
>
> Attachments: GIRAPH-90.diff
>
>
> iterator() implementation returns LongWritable which is cached in a final variable and set() with the new value at next(). This could be misleading as the user might create a list from the iterator's data. Something similar is happening in the getMsgList() as well.
> Is this really what we want?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-90) LongDoubleFloatDoubleVertex has
possibily the iterator() implementation broken
Posted by "Jake Mannix (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151532#comment-13151532 ]
Jake Mannix commented on GIRAPH-90:
-----------------------------------
It's probably not what we want, no. LongWritables are cheap, let's make new ones and return those.
> LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken
> ------------------------------------------------------------------------------
>
> Key: GIRAPH-90
> URL: https://issues.apache.org/jira/browse/GIRAPH-90
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Fix For: 0.70.0
>
>
> iterator() implementation returns LongWritable which is cached in a final variable and set() with the new value at next(). This could be misleading as the user might create a list from the iterator's data. Something similar is happening in the getMsgList() as well.
> Is this really what we want?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira