You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by cpsloal <gi...@git.apache.org> on 2015/09/11 00:35:12 UTC

[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

GitHub user cpsloal opened a pull request:

    https://github.com/apache/cordova-docs/pull/339

    Adding Visual Studio and TACO-CLI to the tools list

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cpsloal/cordova-docs cordova-website

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #339
    
----
commit 0bcfed8018484ba1032b6d75ae25b79017c2e9f2
Author: cpsloal <cp...@yahoo.com>
Date:   2015-09-10T22:32:47Z

    Adding Visual Studio and TACO-CLI to the tools list

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by cpsloal <gi...@git.apache.org>.
Github user cpsloal closed the pull request at:

    https://github.com/apache/cordova-docs/pull/339


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by cpsloal <gi...@git.apache.org>.
Github user cpsloal commented on the pull request:

    https://github.com/apache/cordova-docs/pull/339#issuecomment-139586294
  
    Updated code with CR feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:

    https://github.com/apache/cordova-docs/pull/339#issuecomment-139477814
  
    Please comment when you feel this PR is ready to be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by cpsloal <gi...@git.apache.org>.
Github user cpsloal commented on the pull request:

    https://github.com/apache/cordova-docs/pull/339#issuecomment-139654863
  
    Thank you :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/339#discussion_r39254800
  
    --- Diff: www/static/css-src/_plugins.scss ---
    @@ -120,6 +120,13 @@
     .plugin-results-show-more {
     	text-align: center;
     	cursor:pointer;
    +	padding: 10px;
    +	background-color: #4CC2E4;
    --- End diff --
    
    Please use `$brand-primary` here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/339#discussion_r39254660
  
    --- Diff: www/static/css-src/_artwork.scss ---
    @@ -0,0 +1,34 @@
    +.iconset {
    +  padding: 100px 0;
    +}
    +
    +.button {
    +    display: block;
    +    background: url(/static/img/sprite.png) no-repeat;
    --- End diff --
    
    Please prefix the URI with `{{ site.baseurl }}`, and put the URL in double-quotation marks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:

    https://github.com/apache/cordova-docs/pull/339#issuecomment-139645307
  
    Merged. Sorry, I forgot the "This closes #339" text.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by cpsloal <gi...@git.apache.org>.
Github user cpsloal commented on the pull request:

    https://github.com/apache/cordova-docs/pull/339#issuecomment-139477962
  
    Done with this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Adding Visual Studio and TACO-CLI to th...

Posted by cpsloal <gi...@git.apache.org>.
Github user cpsloal commented on the pull request:

    https://github.com/apache/cordova-docs/pull/339#issuecomment-139481612
  
    Ok, done for reals now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org