[GitHub] [activemq] PascalSchumacher opened a new pull request #505: Avoid potential overflow in int multiplication before it is converted…

[GitBox <gi...@apache.org>]

PascalSchumacher opened a new pull request #505: Avoid potential overflow in int multiplication before it is converted…
URL: https://github.com/apache/activemq/pull/505
 
 
   … to long.
   
   Found by static code analysis: https://lgtm.com/projects/g/apache/activemq?mode=tree&ruleFocus=7900075
   
   At least in some cases (did not check every case) this can not occur because of the range of the variables in use.
   
   Not sure if it is worth merging this non the less. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq] jbonofre commented on issue #505: Avoid potential overflow in int multiplication before it is converted…

[GitBox <gi...@apache.org>]

jbonofre commented on issue #505: Avoid potential overflow in int multiplication before it is converted…
URL: https://github.com/apache/activemq/pull/505#issuecomment-596334520
 
 
   Let me take a look if it's worth to merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services