You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datafu.apache.org by "Philip (flip) Kromer" <fl...@infochimps.com> on 2014/05/20 11:27:02 UTC
Review Request 21684: DATAFU-50: SimpleEvalFunc should extend
ContextualEvalFunc, have good lifecycle hooks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21684/
-----------------------------------------------------------
Review request for DataFu and Matthew Hayes.
Bugs: DATAFU-50
https://issues.apache.org/jira/browse/DATAFU-50
Repository: datafu
Description
-------
* SimpleEvalFunc now extends ContextualEvalFunc (rather than plain-old-EvalFunc), letting front end talk to back end
* ContextualEvalFunc has a hook method onReady(in_schema, out_schema) -- this is sugar for UDFs that simply want an opportunity to capture or set values once for a job, rather than legitimately wanting to override outputSchema().
* Updates AliasableEvalFunc to use onReady
Diffs
-----
datafu-pig/src/main/java/datafu/pig/sets/SetDifference.java b6469e9
datafu-pig/src/main/java/datafu/pig/util/AliasableEvalFunc.java ee2c3f3
datafu-pig/src/main/java/datafu/pig/util/ContextualEvalFunc.java c534b77
datafu-pig/src/main/java/datafu/pig/util/SimpleEvalFunc.java 2d262b4
datafu-pig/src/test/java/datafu/test/pig/util/EvalFuncTests.java PRE-CREATION
datafu-pig/src/test/java/datafu/test/pig/util/SchemaToString.java PRE-CREATION
Diff: https://reviews.apache.org/r/21684/diff/
Testing
-------
Thanks,
Philip (flip) Kromer
Re: Review Request 21684: DATAFU-50: SimpleEvalFunc should extend
ContextualEvalFunc, have good lifecycle hooks
Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21684/#review43484
-----------------------------------------------------------
Ship it!
Ship It!
- Matthew Hayes
On May 20, 2014, 9:27 a.m., Philip (flip) Kromer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21684/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 9:27 a.m.)
>
>
> Review request for DataFu and Matthew Hayes.
>
>
> Bugs: DATAFU-50
> https://issues.apache.org/jira/browse/DATAFU-50
>
>
> Repository: datafu
>
>
> Description
> -------
>
> * SimpleEvalFunc now extends ContextualEvalFunc (rather than plain-old-EvalFunc), letting front end talk to back end
> * ContextualEvalFunc has a hook method onReady(in_schema, out_schema) -- this is sugar for UDFs that simply want an opportunity to capture or set values once for a job, rather than legitimately wanting to override outputSchema().
> * Updates AliasableEvalFunc to use onReady
>
>
> Diffs
> -----
>
> datafu-pig/src/main/java/datafu/pig/sets/SetDifference.java b6469e9
> datafu-pig/src/main/java/datafu/pig/util/AliasableEvalFunc.java ee2c3f3
> datafu-pig/src/main/java/datafu/pig/util/ContextualEvalFunc.java c534b77
> datafu-pig/src/main/java/datafu/pig/util/SimpleEvalFunc.java 2d262b4
> datafu-pig/src/test/java/datafu/test/pig/util/EvalFuncTests.java PRE-CREATION
> datafu-pig/src/test/java/datafu/test/pig/util/SchemaToString.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21684/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Philip (flip) Kromer
>
>