You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2025/12/04 09:10:32 UTC
[PR] chore(ci): add main branch build validation and concurrency control [camel]
gnodet opened a new pull request, #20226:
URL: https://github.com/apache/camel/pull/20226
Add a new workflow to validate commits pushed to main and LTS branches:
- Runs full build and tests on push to main, camel-4.4.x, camel-4.8.x, camel-4.10.x, and camel-4.14.x branches
- Tests with both Java 17 and Java 21
- Includes build artifact archival for debugging
Add concurrency control to PR workflows to prevent resource waste:
- pr-build-main.yml: Cancel in-progress runs when PR is updated
- pr-comment.yml: Cancel in-progress runs for same issue
- pr-doc-validation.yml: Cancel in-progress runs when PR is updated
- depsreview.yaml: Cancel in-progress runs when PR is updated
This ensures the main branch is always validated after merges and reduces CI queue times by cancelling obsolete workflow runs.
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): add main branch build validation and concurrency control [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #20226:
URL: https://github.com/apache/camel/pull/20226#issuecomment-4004396499
Closing and recreating as a fresh PR with the rebased branch on current main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): add main branch build validation and concurrency control [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #20226:
URL: https://github.com/apache/camel/pull/20226#discussion_r2721385600
##########
.github/workflows/main-build.yml:
##########
@@ -0,0 +1,94 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Main Branch Build
+
+on:
+ push:
+ branches:
+ - main
+ - camel-4.4.x
+ - camel-4.8.x
+ - camel-4.10.x
+ - camel-4.14.x
+ paths-ignore:
+ - README.md
+ - SECURITY.md
+ - NOTICE.txt
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ build:
+ if: github.repository == 'apache/camel'
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: ['17', '21']
Review Comment:
I think it would make more sense to keep the main build against all supported JVM and reduce the build in the PR to run only against the latest JVM rather than the opposite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): add main branch build validation and concurrency control [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet closed pull request #20226: chore(ci): add main branch build validation and concurrency control
URL: https://github.com/apache/camel/pull/20226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): add main branch build validation and concurrency control [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #20226:
URL: https://github.com/apache/camel/pull/20226#discussion_r2588375624
##########
.github/workflows/main-build.yml:
##########
@@ -0,0 +1,94 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Main Branch Build
+
+on:
+ push:
+ branches:
+ - main
+ - camel-4.4.x
Review Comment:
I'd keep only last 2 LTS instead. Altough this is not really affecting as we don't merge anything to older branches, it could be perceived as an argument for users which expects longer timeline maintenance for those older branches.
##########
.github/workflows/main-build.yml:
##########
@@ -0,0 +1,94 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Main Branch Build
+
+on:
+ push:
+ branches:
+ - main
+ - camel-4.4.x
+ - camel-4.8.x
+ - camel-4.10.x
+ - camel-4.14.x
+ paths-ignore:
+ - README.md
+ - SECURITY.md
+ - NOTICE.txt
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ build:
+ if: github.repository == 'apache/camel'
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: ['17', '21']
Review Comment:
For the merge I'd reduce the quantity of resources by only checking against the latest JVM supported instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org